git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 58bc474)
Remove superflous variable from xlogreader's XLogFindNextRecord().
Sun, 4 Jan 2015 14:35:46 +0000 (15:35 +0100)
Sun, 4 Jan 2015 14:35:46 +0000 (15:35 +0100)
Pointed out by Coverity.

Since this is mere, and debatable, cosmetics I'm not backpatching
this.


diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/transam/xlogreader.c
index 67d62234369d2d904f1adb78da22d5f13080e777..db5384c2062c3efe81957e1cc93a4249b04e2dc7 100644 (file)
--- a/src/backend/access/transam/xlogreader.c
+++ b/src/backend/access/transam/xlogreader.c
@@ -833,7 +833,6 @@ XLogFindNextRecord(XLogReaderState *state, XLogRecPtr RecPtr)
XLogRecPtr found = InvalidXLogRecPtr;
uint32 pageHeaderSize;
XLogPageHeader header;
- XLogRecord *record;
int readLen;
char *errormsg;
@@ -875,7 +874,7 @@ XLogFindNextRecord(XLogReaderState *state, XLogRecPtr RecPtr)
* because either we're at the first record after the beginning of a page
* or we just jumped over the remaining data of a continuation.
*/
- while ((record = XLogReadRecord(state, tmpRecPtr, &errormsg)))
+ while (XLogReadRecord(state, tmpRecPtr, &errormsg) != NULL)
{
/* continue after the record */
tmpRecPtr = InvalidXLogRecPtr;
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /