git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Disallow server start with sync_replication_slots = on and wal_level < logical.

author Fujii Masao <fujii@postgresql.org>

2025年8月21日 13:18:11 +0000 (22:18 +0900)

committer Fujii Masao <fujii@postgresql.org>

2025年8月21日 13:18:11 +0000 (22:18 +0900)

Replication slot synchronization (sync_replication_slots = on)
requires wal_level to be logical. This commit prevents the server
from starting if sync_replication_slots is enabled but wal_level
is set to minimal or replica.

Failing early during startup helps users catch invalid configurations
immediately, which is important because changing wal_level requires
a server restart.

Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Shveta Malik <shveta.malik@gmail.com>
Discussion: https://postgr.es/m/CAH0PTU_pc3oHi__XESF9ZigCyzai1Mo3LsOdFyQA4aUDkm01RA@mail.gmail.com

src/backend/postmaster/postmaster.c patch | blob | blame | history

diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c

index e01d9f0cfe81e1067a1d372327ae8b7759e2869d..e1d643b013d77caf3ac51a52311c0a561d981d8f 100644 (file)

--- a/src/backend/postmaster/postmaster.c

+++ b/src/backend/postmaster/postmaster.c

@@ -854,6 +854,9 @@ PostmasterMain(int argc, char *argv[])

if (summarize_wal && wal_level == WAL_LEVEL_MINIMAL)

ereport(ERROR,

(errmsg("WAL cannot be summarized when \"wal_level\" is \"minimal\"")));

+ if (sync_replication_slots && wal_level < WAL_LEVEL_LOGICAL)

+ ereport(ERROR,

+ (errmsg("replication slot synchronization (\"sync_replication_slots\" = on) requires \"wal_level\" >= \"logical\"")));

* Other one-time internal sanity checks can go here, if they are fast.

This is the main PostgreSQL git repository.

RSS Atom