git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Add comment to explain an unused function parameter

author David Rowley <drowley@postgresql.org>

2020年7月14日 05:29:52 +0000 (17:29 +1200)

committer David Rowley <drowley@postgresql.org>

2020年7月14日 05:29:52 +0000 (17:29 +1200)

Removing the unused 'miinfo' parameter has been raised a couple of times
now. It was decided in the 2nd discussion below that we're going to leave
it alone. It seems like it might be useful to add a comment to mention
this fact so that nobody wastes any time in the future proposing its
removal again.

Discussion: https://postgr.es/m/CAApHDvpCf-qR5HC1rXskUM4ToV+3YDb4-n1meY=vpAHsRS_1PA@mail.gmail.com
Discussion: https://postgr.es/m/CAE9k0P%3DFvcDswnSVtRpSyZMpcAWC%3DGp%3DifZ0HdfPaRQ%3D__LBtw%40mail.gmail.com

src/backend/commands/copy.c patch | blob | blame | history

diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c

index 99d14571801224ba8cfe4bf87829ae0ec8db2e65..44da71c4cb5cad1027086e3a59d3420d25e78cad 100644 (file)

--- a/src/backend/commands/copy.c

+++ b/src/backend/commands/copy.c

@@ -2604,6 +2604,9 @@ CopyMultiInsertInfoCleanup(CopyMultiInsertInfo *miinfo)

* Get the next TupleTableSlot that the next tuple should be stored in.

* Callers must ensure that the buffer is not full.

+ *

+ * Note: 'miinfo' is unused but has been included for consistency with the

+ * other functions in this area.

static inline TupleTableSlot *

CopyMultiInsertInfoNextFreeSlot(CopyMultiInsertInfo *miinfo,

This is the main PostgreSQL git repository.

RSS Atom