git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Increase hard-wired timeout values in ecpg regression tests.

Tue, 4 Aug 2020 19:20:31 +0000 (15:20 -0400)

A couple of test cases had connect_timeout=14, a value that seems
to have been plucked from a hat. While it's more than sufficient
for normal cases, slow/overloaded buildfarm machines can get a timeout
failure here, as per recent report from "sungazer". Increase to 180
seconds, which is in line with our typical timeouts elsewhere in
the regression tests.

Back-patch to 9.6; the code looks different in 9.5, and this doesn't
seem to be quite worth the effort to adapt to that.

Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sungazer&dt=2020年08月04日%2007%3A12%3A22

src/interfaces/ecpg/test/connect/test1.pgc patch | blob | blame | history

src/interfaces/ecpg/test/connect/test5.pgc patch | blob | blame | history

src/interfaces/ecpg/test/expected/connect-test1-minGW32.stderr patch | blob | blame | history

src/interfaces/ecpg/test/expected/connect-test1.c patch | blob | blame | history

src/interfaces/ecpg/test/expected/connect-test1.stderr patch | blob | blame | history

src/interfaces/ecpg/test/expected/connect-test5.c patch | blob | blame | history

src/interfaces/ecpg/test/expected/connect-test5.stderr patch | blob | blame | history

diff --git a/src/interfaces/ecpg/test/connect/test1.pgc b/src/interfaces/ecpg/test/connect/test1.pgc

index 82cdfb8fc56e58233ea2786dae116a9526b4f869..961bd72ef2a920198ddfc804f6c0b8d8c67c4332 100644 (file)

--- a/src/interfaces/ecpg/test/connect/test1.pgc

+++ b/src/interfaces/ecpg/test/connect/test1.pgc

@@ -46,7 +46,7 @@ exec sql end declare section;

exec sql connect to unix:postgresql://localhost/ecpg2_regression user regress_ecpg_user1 using "connectpw";

exec sql disconnect;

- exec sql connect to unix:postgresql://localhost/ecpg2_regression?connect_timeout=14 user regress_ecpg_user1;

+ exec sql connect to unix:postgresql://localhost/ecpg2_regression?connect_timeout=180 user regress_ecpg_user1;

exec sql disconnect;

/* wrong db */

diff --git a/src/interfaces/ecpg/test/connect/test5.pgc b/src/interfaces/ecpg/test/connect/test5.pgc

index 2e34ab84fc6264f5513aaeaab20ac3cfeeb481a0..e712fa87783fb249c3900bd8a77f572a28f1b150 100644 (file)

--- a/src/interfaces/ecpg/test/connect/test5.pgc

+++ b/src/interfaces/ecpg/test/connect/test5.pgc

@@ -55,7 +55,7 @@ exec sql end declare section;

exec sql connect to 'unix:postgresql://localhost/ecpg2_regression' as main user :user USING "connectpw";

exec sql disconnect main;

- exec sql connect to unix:postgresql://localhost/ecpg2_regression?connect_timeout=14&client_encoding=latin1 as main user regress_ecpg_user1/connectpw;

+ exec sql connect to unix:postgresql://localhost/ecpg2_regression?connect_timeout=180&client_encoding=latin1 as main user regress_ecpg_user1/connectpw;

exec sql disconnect main;

exec sql connect to "unix:postgresql://200.46.204.71/ecpg2_regression" as main user regress_ecpg_user1/connectpw;

diff --git a/src/interfaces/ecpg/test/expected/connect-test1-minGW32.stderr b/src/interfaces/ecpg/test/expected/connect-test1-minGW32.stderr

index b334537b60055545639d3533930a6c2ae6ba4112..853453d980ece85e1d25d6c262f5c683b515fcfb 100644 (file)

--- a/src/interfaces/ecpg/test/expected/connect-test1-minGW32.stderr

+++ b/src/interfaces/ecpg/test/expected/connect-test1-minGW32.stderr

@@ -48,7 +48,7 @@

[NO_PID]: sqlca: code: 0, state: 00000

[NO_PID]: ecpg_finish: connection ecpg2_regression closed

[NO_PID]: sqlca: code: 0, state: 00000

-[NO_PID]: ECPGconnect: opening database ecpg2_regression on <DEFAULT> port <DEFAULT> with options connect_timeout=14 for user regress_ecpg_user1

+[NO_PID]: ECPGconnect: opening database ecpg2_regression on <DEFAULT> port <DEFAULT> with options connect_timeout=180 for user regress_ecpg_user1

[NO_PID]: sqlca: code: 0, state: 00000

[NO_PID]: ecpg_finish: connection ecpg2_regression closed

[NO_PID]: sqlca: code: 0, state: 00000

diff --git a/src/interfaces/ecpg/test/expected/connect-test1.c b/src/interfaces/ecpg/test/expected/connect-test1.c

index 894273339cd2d517a3e6a62bd74c44d40a766470..ffd24e2fc8f4e3e19100b9f5965cfc921b2633a5 100644 (file)

--- a/src/interfaces/ecpg/test/expected/connect-test1.c

+++ b/src/interfaces/ecpg/test/expected/connect-test1.c

@@ -93,7 +93,7 @@ main(void)

#line 47 "test1.pgc"

- { ECPGconnect(__LINE__, 0, "unix:postgresql://localhost/ecpg2_regression?connect_timeout=14" , "regress_ecpg_user1" , NULL , NULL, 0); }

+ { ECPGconnect(__LINE__, 0, "unix:postgresql://localhost/ecpg2_regression?connect_timeout=180" , "regress_ecpg_user1" , NULL , NULL, 0); }

#line 49 "test1.pgc"

{ ECPGdisconnect(__LINE__, "CURRENT");}

diff --git a/src/interfaces/ecpg/test/expected/connect-test1.stderr b/src/interfaces/ecpg/test/expected/connect-test1.stderr

index c5cbf749efeab62042b941d466896c79dadbb584..1986fc54adc27208a37b2aaa2732636dd6f1ea51 100644 (file)

--- a/src/interfaces/ecpg/test/expected/connect-test1.stderr

+++ b/src/interfaces/ecpg/test/expected/connect-test1.stderr

@@ -48,7 +48,7 @@

[NO_PID]: sqlca: code: 0, state: 00000

[NO_PID]: ecpg_finish: connection ecpg2_regression closed

[NO_PID]: sqlca: code: 0, state: 00000

-[NO_PID]: ECPGconnect: opening database ecpg2_regression on <DEFAULT> port <DEFAULT> with options connect_timeout=14 for user regress_ecpg_user1

+[NO_PID]: ECPGconnect: opening database ecpg2_regression on <DEFAULT> port <DEFAULT> with options connect_timeout=180 for user regress_ecpg_user1

[NO_PID]: sqlca: code: 0, state: 00000

[NO_PID]: ecpg_finish: connection ecpg2_regression closed

[NO_PID]: sqlca: code: 0, state: 00000

diff --git a/src/interfaces/ecpg/test/expected/connect-test5.c b/src/interfaces/ecpg/test/expected/connect-test5.c

index b44104854da08f60a352bc9be13becd6f663a31c..6ae5b589dea4f95ef9ce736d166b3bcd8f09e664 100644 (file)

--- a/src/interfaces/ecpg/test/expected/connect-test5.c

+++ b/src/interfaces/ecpg/test/expected/connect-test5.c

@@ -121,7 +121,7 @@ main(void)

#line 56 "test5.pgc"

- { ECPGconnect(__LINE__, 0, "unix:postgresql://localhost/ecpg2_regression?connect_timeout=14 & client_encoding=latin1" , "regress_ecpg_user1" , "connectpw" , "main", 0); }

+ { ECPGconnect(__LINE__, 0, "unix:postgresql://localhost/ecpg2_regression?connect_timeout=180 & client_encoding=latin1" , "regress_ecpg_user1" , "connectpw" , "main", 0); }

#line 58 "test5.pgc"

{ ECPGdisconnect(__LINE__, "main");}

diff --git a/src/interfaces/ecpg/test/expected/connect-test5.stderr b/src/interfaces/ecpg/test/expected/connect-test5.stderr

index cefdb0739e5b46ddf666ee5032b464dd5226ec12..a54df175fbf0db018cfb7a76ec13e0aeb1a69e23 100644 (file)

--- a/src/interfaces/ecpg/test/expected/connect-test5.stderr

+++ b/src/interfaces/ecpg/test/expected/connect-test5.stderr

@@ -61,7 +61,7 @@

[NO_PID]: sqlca: code: 0, state: 00000

[NO_PID]: ecpg_finish: connection main closed

[NO_PID]: sqlca: code: 0, state: 00000

-[NO_PID]: ECPGconnect: opening database ecpg2_regression on <DEFAULT> port <DEFAULT> with options connect_timeout=14 & client_encoding=latin1 for user regress_ecpg_user1

+[NO_PID]: ECPGconnect: opening database ecpg2_regression on <DEFAULT> port <DEFAULT> with options connect_timeout=180 & client_encoding=latin1 for user regress_ecpg_user1

[NO_PID]: sqlca: code: 0, state: 00000

[NO_PID]: ecpg_finish: connection main closed

[NO_PID]: sqlca: code: 0, state: 00000

This is the main PostgreSQL git repository.

RSS Atom