git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Clean up a bug in sql/json items commit 66ea94e8e6

author Andrew Dunstan <andrew@dunslane.net>

2024年1月25日 21:21:57 +0000 (16:21 -0500)

committer Andrew Dunstan <andrew@dunslane.net>

2024年1月25日 21:25:11 +0000 (16:25 -0500)

Remove a buggy and unnecessary test, along with an unnecessary pstrdup()
and a line of dead code.

Per report, diagnosis and fix from Tom Lane

Discussion: https://postgr.es/m/439811.1706211069@sss.pgh.pa.us

src/backend/utils/adt/jsonpath_exec.c patch | blob | blame | history

diff --git a/src/backend/utils/adt/jsonpath_exec.c b/src/backend/utils/adt/jsonpath_exec.c

index bf37f0195c84730f055d1d16ac2f802e7d138d02..02a700292bbc036450af2db0370940466d520dc7 100644 (file)

--- a/src/backend/utils/adt/jsonpath_exec.c

+++ b/src/backend/utils/adt/jsonpath_exec.c

@@ -1540,11 +1540,9 @@ executeItemOptUnwrapTarget(JsonPathExecContext *cxt, JsonPathItem *jsp,

break;

}

- res = jperOk;

jb = &jbv;

Assert(tmp != NULL); /* We must have set tmp above */

- jb->val.string.val = (jb->type == jbvString) ? tmp : pstrdup(tmp);

+ jb->val.string.val = tmp;

jb->val.string.len = strlen(jb->val.string.val);

jb->type = jbvString;

This is the main PostgreSQL git repository.

RSS Atom