git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Correct obsolete nbtree page deletion comment.

2019年2月26日 00:54:18 +0000 (16:54 -0800)

Commit efada2b8e92, which made the nbtree page deletion algorithm more
robust, removed _bt_getstackbuf() calls from _bt_pagedel(). It failed
to update a comment that referenced the earlier approach. Update the
comment to explain that the _bt_getstackbuf() page deletion call site
mirrors the only other remaining _bt_getstackbuf() call site, which is
reached during page splits.

src/backend/access/nbtree/nbtpage.c patch | blob | blame | history

diff --git a/src/backend/access/nbtree/nbtpage.c b/src/backend/access/nbtree/nbtpage.c

index 1d72fe54081b49e12247193e4d6ec7da1baad9b2..300daf915da6a6ffc2c8f74c78f27565077d7571 100644 (file)

--- a/src/backend/access/nbtree/nbtpage.c

+++ b/src/backend/access/nbtree/nbtpage.c

@@ -1124,9 +1124,10 @@ _bt_is_page_halfdead(Relation rel, BlockNumber blk)

* "child" is the leaf page we wish to delete, and "stack" is a search stack

* leading to it (approximately). Note that we will update the stack

- * entry(s) to reflect current downlink positions --- this is harmless and

- * indeed saves later search effort in _bt_pagedel. The caller should

- * initialize *target and *rightsib to the leaf page and its right sibling.

+ * entry(s) to reflect current downlink positions --- this is essentially the

+ * same as the corresponding step of splitting, and is not expected to affect

+ * caller. The caller should initialize *target and *rightsib to the leaf

+ * page and its right sibling.

* Note: it's OK to release page locks on any internal pages between the leaf

* and *topparent, because a safe deletion can't become unsafe due to

This is the main PostgreSQL git repository.

RSS Atom