git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Fix variable lifespan in ExecInitCoerceToDomain().

Tue, 2 Nov 2021 17:36:47 +0000 (13:36 -0400)

This undoes a mistake in 1ec7679f1: domainval and domainnull were
meant to live across loop iterations, but they were incorrectly
moved inside the loop. The effect was only to emit useless extra
EEOP_MAKE_READONLY steps, so it's not a big deal; nonetheless,
back-patch to v13 where the mistake was introduced.

Ranier Vilela

Discussion: https://postgr.es/m/CAEudQAqXuhbkaAp-sGH6dR6Nsq7v28_0TPexHOm6FiDYqwQD-w@mail.gmail.com

src/backend/executor/execExpr.c patch | blob | blame | history

diff --git a/src/backend/executor/execExpr.c b/src/backend/executor/execExpr.c

index 33ef39e2d4c338a7c661372cfa77e0c7a088b35e..892b4e17e09dfd50c3cc54c5a9bdb33292e788ef 100644 (file)

--- a/src/backend/executor/execExpr.c

+++ b/src/backend/executor/execExpr.c

@@ -3137,6 +3137,8 @@ ExecInitCoerceToDomain(ExprEvalStep *scratch, CoerceToDomain *ctest,

ExprState *state, Datum *resv, bool *resnull)

{

DomainConstraintRef *constraint_ref;

+ Datum *domainval = NULL;

+ bool *domainnull = NULL;

ListCell *l;