git.postgresql.org Git - postgresql.git/commit

git projects / postgresql.git / commit

summary | shortlog | log | commit | commitdiff | tree
(parent: 88543ec) | patch

Pass collations to functions in FunctionCallInfoData, not FmgrInfo.

author Tom Lane <tgl@sss.pgh.pa.us>

2011年4月12日 23:19:24 +0000 (19:19 -0400)

committer Tom Lane <tgl@sss.pgh.pa.us>

2011年4月12日 23:19:24 +0000 (19:19 -0400)

commit d64713df7e5996ab3ab337b5e0901cf2c53773f9

tree 7105a61bf9fef5cef674cea7f1305dfeb77aa39a tree

parent 88543ecfec9c754b5f14b898bccbc68d941748b3 commit | diff

Pass collations to functions in FunctionCallInfoData, not FmgrInfo.

Since collation is effectively an argument, not a property of the function,
FmgrInfo is really the wrong place for it; and this becomes critical in
cases where a cached FmgrInfo is used for varying purposes that might need
different collation settings. Fix by passing it in FunctionCallInfoData
instead. In particular this allows a clean fix for bug #5970 (record_cmp
not working). This requires touching a bit more code than the original
method, but nobody ever thought that collations would not be an invasive
patch...

49 files changed:

contrib/btree_gin/btree_gin.c diff | blob | blame | history

contrib/btree_gist/btree_text.c diff | blob | blame | history

src/backend/access/common/reloptions.c diff | blob | blame | history

src/backend/access/common/scankey.c diff | blob | blame | history

src/backend/access/gin/ginget.c diff | blob | blame | history

src/backend/access/gin/ginutil.c diff | blob | blame | history

src/backend/access/gist/gistget.c diff | blob | blame | history

src/backend/access/gist/gistscan.c diff | blob | blame | history

src/backend/access/hash/hashutil.c diff | blob | blame | history

src/backend/access/index/indexam.c diff | blob | blame | history

src/backend/access/nbtree/nbtinsert.c diff | blob | blame | history

src/backend/access/nbtree/nbtsearch.c diff | blob | blame | history

src/backend/access/nbtree/nbtsort.c diff | blob | blame | history

src/backend/access/nbtree/nbtutils.c diff | blob | blame | history

src/backend/commands/analyze.c diff | blob | blame | history

src/backend/commands/trigger.c diff | blob | blame | history

src/backend/commands/tsearchcmds.c diff | blob | blame | history

src/backend/executor/execGrouping.c diff | blob | blame | history

src/backend/executor/execQual.c diff | blob | blame | history

src/backend/executor/execUtils.c diff | blob | blame | history

src/backend/executor/functions.c diff | blob | blame | history

src/backend/executor/nodeAgg.c diff | blob | blame | history

src/backend/executor/nodeIndexscan.c diff | blob | blame | history

src/backend/executor/nodeMergeAppend.c diff | blob | blame | history

src/backend/executor/nodeMergejoin.c diff | blob | blame | history

src/backend/executor/nodeSubplan.c diff | blob | blame | history

src/backend/executor/nodeWindowAgg.c diff | blob | blame | history

src/backend/optimizer/path/indxpath.c diff | blob | blame | history

src/backend/tcop/fastpath.c diff | blob | blame | history

src/backend/tsearch/wparser.c diff | blob | blame | history

src/backend/utils/adt/arrayfuncs.c diff | blob | blame | history

src/backend/utils/adt/int.c diff | blob | blame | history

src/backend/utils/adt/like.c diff | blob | blame | history

src/backend/utils/adt/oid.c diff | blob | blame | history

src/backend/utils/adt/ri_triggers.c diff | blob | blame | history

src/backend/utils/adt/rowtypes.c diff | blob | blame | history

src/backend/utils/adt/selfuncs.c diff | blob | blame | history

src/backend/utils/cache/catcache.c diff | blob | blame | history

src/backend/utils/fmgr/README diff | blob | blame | history

src/backend/utils/fmgr/fmgr.c diff | blob | blame | history

src/backend/utils/sort/tuplesort.c diff | blob | blame | history

src/include/access/gin_private.h diff | blob | blame | history

src/include/access/skey.h diff | blob | blame | history

src/include/access/valid.h diff | blob | blame | history

src/include/fmgr.h diff | blob | blame | history

src/include/nodes/execnodes.h diff | blob | blame | history

src/include/utils/selfuncs.h diff | blob | blame | history

src/include/utils/tuplesort.h diff | blob | blame | history

src/pl/plpgsql/src/pl_comp.c diff | blob | blame | history

This is the main PostgreSQL git repository.