git.postgresql.org Git - postgresql.git/commit

git projects / postgresql.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: fb53c4c) | patch
Fix integer-overflow edge case detection in interval_mul and pgbench.
Thu, 7 Nov 2019 16:22:52 +0000 (11:22 -0500)
Thu, 7 Nov 2019 16:23:00 +0000 (11:23 -0500)
commit b49b7f94489a12d0d7d299b2871c4881fa3c5d49
Fix integer-overflow edge case detection in interval_mul and pgbench.

This patch adopts the overflow check logic introduced by commit cbdb8b4c0
into two more places. interval_mul() failed to notice if it computed a
new microseconds value that was one more than INT64_MAX, and pgbench's
double-to-int64 logic had the same sorts of edge-case problems that
cbdb8b4c0 fixed in the core code.

To make this easier to get right in future, put the guts of the checks
into new macros in c.h, and add commentary about how to use the macros
correctly.

Back-patch to all supported branches, as we did with the previous fix.

Yuya Watari

Discussion: https://postgr.es/m/CAJ2pMkbkkFw2hb9Qb1Zj8d06EhWAQXFLy73St4qWv6aX=vqnjw@mail.gmail.com
src/backend/utils/adt/float.c diff | blob | blame | history
src/backend/utils/adt/int8.c diff | blob | blame | history
src/backend/utils/adt/timestamp.c diff | blob | blame | history
src/bin/pgbench/pgbench.c diff | blob | blame | history
src/include/c.h diff | blob | blame | history
src/test/regress/expected/interval.out diff | blob | blame | history
src/test/regress/sql/interval.sql diff | blob | blame | history
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /