git.postgresql.org Git - postgresql.git/commit

git projects / postgresql.git / commit

Move portal pinning from PL/pgSQL to SPI

author Peter Eisentraut <peter_e@gmx.net>

2017年12月15日 20:24:10 +0000 (15:24 -0500)

committer Peter Eisentraut <peter_e@gmx.net>

2018年1月10日 15:20:51 +0000 (10:20 -0500)

commit b3617cdfbba1b5381e9d1c6bc0839500e8eb7273

tree a2c29bd9c2b47c1ebea6e0532b8067d55d3c81b4 tree

parent acc67ffd0a8c728b928958e75b76ee544b64c2d8 commit | diff

Move portal pinning from PL/pgSQL to SPI

PL/pgSQL "pins" internally generated (unnamed) portals so that user code
cannot close them by guessing their names. This logic is also useful in
other languages and really for any code. So move that logic into SPI.
An unnamed portal obtained through SPI_cursor_open() and related
functions is now automatically pinned, and SPI_cursor_close()
automatically unpins a portal that is pinned.

In the core distribution, this affects PL/Perl and PL/Python, preventing
users from manually closing cursors created by spi_query and
plpy.cursor, respectively. (PL/Tcl does not currently offer any cursor
functionality.)

Reviewed-by: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

src/backend/executor/spi.c diff | blob | blame | history

src/pl/plpgsql/src/pl_exec.c diff | blob | blame | history

This is the main PostgreSQL git repository.

RSS Atom