git.postgresql.org Git - postgresql.git/commit

git projects / postgresql.git / commit

Fix the handling of the failover option in subscription commands.

author Amit Kapila <akapila@postgresql.org>

2024年4月23日 06:44:57 +0000 (12:14 +0530)

committer Amit Kapila <akapila@postgresql.org>

2024年4月23日 06:52:30 +0000 (12:22 +0530)

commit b29cbd3da4e37db17026b9fe58fb46fe83f467bf

tree 30134e35c65ff9e7ec50e7288a353fd00f570290 tree

parent 480bc6e3ed3a5719cdec076d4943b119890e8171 commit | diff

Fix the handling of the failover option in subscription commands.

Do not allow ALTER SUBSCRIPTION ... SET (failover = on|off) in a
transaction block as the changed failover option of the slot can't be
rolled back. For the same reason, we refrain from altering the replication
slot's failover property if the subscription is created with a valid
slot_name and create_slot=false.

Reprted-by: Kuroda Hayato
Author: Hou Zhijie
Reviewed-by: Shveta Malik, Bertrand Drouvot, Kuroda Hayato
Discussion: https://postgr.es/m/OS0PR01MB57165542B09DFA4943830BF294082@OS0PR01MB5716.jpnprd01.prod.outlook.com

doc/src/sgml/ref/alter_subscription.sgml diff | blob | blame | history

doc/src/sgml/ref/create_subscription.sgml diff | blob | blame | history

doc/src/sgml/ref/pg_dump.sgml diff | blob | blame | history

src/backend/commands/subscriptioncmds.c diff | blob | blame | history

src/bin/pg_dump/pg_dump.c diff | blob | blame | history

src/test/recovery/t/040_standby_failover_slots_sync.pl diff | blob | blame | history

src/test/regress/expected/subscription.out diff | blob | blame | history

src/test/regress/sql/subscription.sql diff | blob | blame | history

This is the main PostgreSQL git repository.

RSS Atom