git.postgresql.org Git - postgresql.git/commit

git projects / postgresql.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: d57eceb) | patch
Fix inconsistent equalfuncs.c behavior for FuncCall.funcformat.
Sun, 6 Jun 2021 19:46:58 +0000 (15:46 -0400)
Sun, 6 Jun 2021 19:46:58 +0000 (15:46 -0400)
commit a65e9f3f1405b786673feec131879843432bf9a6
Fix inconsistent equalfuncs.c behavior for FuncCall.funcformat.

Other equalfuncs.c checks on CoercionForm fields use
COMPARE_COERCIONFORM_FIELD (which makes them no-ops),
but commit 40c24bfef neglected to make _equalFuncCall
do likewise. Fix that.

This is only strictly correct if FuncCall.funcformat has
no semantic effect, instead just determining ruleutils.c
display formatting. 40c24bfef added a couple of checks
in parse analysis that could break that rule; but on closer
inspection, they're redundant, so just take them out again.

Per report from Noah Misch.

Discussion: https://postgr.es/m/20210606063331.GC297923@rfd.leadboat.com
src/backend/nodes/equalfuncs.c diff | blob | blame | history
src/backend/parser/parse_clause.c diff | blob | blame | history
src/backend/parser/parse_func.c diff | blob | blame | history
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /