git.postgresql.org Git - postgresql.git/commit

git projects / postgresql.git / commit

isdigit() needs an unsigned char argument.

author Heikki Linnakangas <heikki.linnakangas@iki.fi>

Thu, 6 Mar 2014 19:19:00 +0000 (21:19 +0200)

committer Heikki Linnakangas <heikki.linnakangas@iki.fi>

Thu, 6 Mar 2014 19:40:10 +0000 (21:40 +0200)

commit a0c2fa9b5cfaf9595e8809a68eec929a5052834e

tree 939f03940d5e9043b1a8a1957eea3f3a98ec5538 tree

parent 94ae6ba74dfc626efa271461902db1be35d2a551 commit | diff

isdigit() needs an unsigned char argument.

Per the C standard, the routine should be passed an int, with a value that's
representable as an unsigned char or EOF. Passing a signed char is wrong,
because a negative value is not representable as an unsigned char.
Unfortunately no compiler warns about that.

src/backend/utils/adt/timestamp.c diff | blob | blame | history

This is the main PostgreSQL git repository.

RSS Atom