git.postgresql.org Git - postgresql.git/commit

git projects / postgresql.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 7e85d1c) | patch
Make GIN tests using injection points concurrent-safe
2024年4月10日 04:48:13 +0000 (13:48 +0900)
2024年4月10日 04:48:13 +0000 (13:48 +0900)
commit 5105c90796811f62711538155d207e5311eacf9b
Make GIN tests using injection points concurrent-safe

f587338dec87 has introduced in the test module injection_points a SQL
function called injection_points_set_local(), that can be used to make
all the injection points linked to the process where they are attached,
discarded automatically if any remain once the process exits.

e2e3b8ae9ed7 has added a NO_INSTALLCHECK to the test module to prevent
the use of installcheck. Now that there is a way to make the test
concurrent-safe, let's use it and remove the installcheck restriction.

Concurrency issues could be easily reproduced by running in a tight
loop a command like this one, in src/test/modules/gin/ (hardcoding
pg_sleep() after attaching injection points enlarges the race window)
and a second test suite like contrib/btree_gin/:

make installcheck USE_MODULE_DB=1

Reviewed-by: Andrey Borodin
Discussion: https://postgr.es/m/ZhNG4Io9uYOgwv3F@paquier.xyz
src/test/modules/gin/Makefile diff | blob | blame | history
src/test/modules/gin/expected/gin_incomplete_splits.out diff | blob | blame | history
src/test/modules/gin/meson.build diff | blob | blame | history
src/test/modules/gin/sql/gin_incomplete_splits.sql diff | blob | blame | history
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /