git.postgresql.org Git - postgresql.git/commit

git projects / postgresql.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 4db819b) | patch
Fix possible future cache reference leak in ALTER EXTENSION ADD/DROP.
2020年4月17日 17:41:59 +0000 (13:41 -0400)
2020年4月17日 17:41:59 +0000 (13:41 -0400)
commit 3125a5baec1cf6d3aaeb8964bc3b3c49835e0452
Fix possible future cache reference leak in ALTER EXTENSION ADD/DROP.

recordExtObjInitPriv and removeExtObjInitPriv were sloppy about
calling ReleaseSysCache. The cases cannot occur given current usage
in ALTER EXTENSION ADD/DROP, since we wouldn't get here for these
relkinds; but it seems wise to clean up better.

In passing, extend test logic in test_pg_dump to exercise the
dropped-column code paths here.

Since the case is unreachable at present, there seems no great
need to back-patch; hence fix HEAD only.

Kyotaro Horiguchi, with test case and comment adjustments by me

Discussion: https://postgr.es/m/20200417.151831.1153577605111650154.horikyota.ntt@gmail.com
src/backend/catalog/aclchk.c diff | blob | blame | history
src/test/modules/test_pg_dump/README diff | blob | blame | history
src/test/modules/test_pg_dump/expected/test_pg_dump.out diff | blob | blame | history
src/test/modules/test_pg_dump/sql/test_pg_dump.sql diff | blob | blame | history
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /