git.postgresql.org Git - postgresql.git/commit

git projects / postgresql.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 773aec7) | patch
Revert "Do execGrouping.c via expression eval machinery."
2018年2月16日 06:39:18 +0000 (22:39 -0800)
2018年2月16日 06:39:18 +0000 (22:39 -0800)
commit 2a41507dab0f293ff241fe8ae326065998668af8
Revert "Do execGrouping.c via expression eval machinery."

This reverts commit 773aec7aa98abd38d6d9435913bb8e14e392c274.

There's an unresolved issue in the reverted commit: It only creates
one comparator function, but in for the nodeSubplan.c case we need
more (c.f. FindTupleHashEntry vs LookupTupleHashEntry calls in
nodeSubplan.c).

This isn't too difficult to fix, but it's not entirely trivial
either. The fact that the issue only causes breakage on 32bit systems
shows that the current test coverage isn't that great. To avoid
turning half the buildfarm red till those two issues are addressed,
revert.
15 files changed:
src/backend/executor/execExpr.c diff | blob | blame | history
src/backend/executor/execExprInterp.c diff | blob | blame | history
src/backend/executor/execGrouping.c diff | blob | blame | history
src/backend/executor/nodeAgg.c diff | blob | blame | history
src/backend/executor/nodeGroup.c diff | blob | blame | history
src/backend/executor/nodeRecursiveunion.c diff | blob | blame | history
src/backend/executor/nodeSetOp.c diff | blob | blame | history
src/backend/executor/nodeSubplan.c diff | blob | blame | history
src/backend/executor/nodeUnique.c diff | blob | blame | history
src/backend/executor/nodeWindowAgg.c diff | blob | blame | history
src/backend/utils/adt/orderedsetaggs.c diff | blob | blame | history
src/include/executor/execExpr.h diff | blob | blame | history
src/include/executor/executor.h diff | blob | blame | history
src/include/executor/nodeAgg.h diff | blob | blame | history
src/include/nodes/execnodes.h diff | blob | blame | history
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /