git.postgresql.org Git - postgresql.git/commit

git projects / postgresql.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 84bc2b1) | patch
Remove useless Asserts in Result Cache code
Fri, 2 Apr 2021 21:41:43 +0000 (10:41 +1300)
Fri, 2 Apr 2021 21:41:43 +0000 (10:41 +1300)
commit 1267d9862fc6a4f8cdc0ca38d1988b61f39da585
Remove useless Asserts in Result Cache code

Testing if an unsigned variable is >= 0 is pretty pointless.

There's likely enough code in remove_cache_entry() to verify the cache
memory accounting is correct in assert enabled builds. These Asserts
were not adding much extra cover, even if they had been checking >= 0 on a
signed variable.

Reported-by: Andres Freund
Discussion: https://postgr.es/m/20210402204734.6mo3nfacnljlicgn@alap3.anarazel.de
src/backend/executor/nodeResultCache.c diff | blob | blame | history
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /