git.postgresql.org Git - postgresql.git/commit

git projects / postgresql.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: f9692a7) | patch
Move estimate_hashagg_tablesize to selfuncs.c, and widen result to double.
2019年2月21日 19:59:02 +0000 (14:59 -0500)
2019年2月21日 19:59:12 +0000 (14:59 -0500)
commit 0c7d53793079a1af3f070d93e3eb86a52720f6e7
Move estimate_hashagg_tablesize to selfuncs.c, and widen result to double.

It seems to make more sense for this to be in selfuncs.c, since it's
largely a statistical-estimation thing, and it's related to other
functions like estimate_hash_bucket_stats that are there.

While at it, change the result type from Size to double. Perhaps at one
point it was impossible for the result to overflow an integer, but
I've got no confidence in that proposition anymore. Nothing's actually
done with the result except to compare it to a work_mem-based limit,
so as long as we don't get an overflow on the way to that comparison,
things should be fine even with very large dNumGroups.

Code movement proposed by Antonin Houska, type change by me

Discussion: https://postgr.es/m/25767.1549359615@localhost
src/backend/optimizer/plan/planner.c diff | blob | blame | history
src/backend/utils/adt/selfuncs.c diff | blob | blame | history
src/include/utils/selfuncs.h diff | blob | blame | history
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /