recent regression

Fri Jun 25 18:27:00 GMT 2004

> Would it not it be better to simply avoid calling read_class in the
> CLASS_FROM_SOURCE_P case? If you have a type decl for a class and
> CLASS_FROM_SOURCE_P is true, then (afaik) it must by definition be
> already loaded and been/being parsed. How about the following patch instead:
[...]
> This would also allow us to get rid of many of the CLASS_FROM_SOURCE_P
> checks scattered around parse.y.

Yes, this is much better. As I mention elsewhere though, we ought
to really clarify what we mean by a "loaded" class. (i.e. load_class()
v/s CLASS_LOADED_P().)
Will you be fleshing this out a bit more to remove the redundant
checks you mention?
Also, if this is the way forward, then you should remove the
comment at the top of load_class() where the author intends
to ask clients to call read_class() directly.
I'll hold back on my patch then.
Thanks,
Ranjit.