confirmed that Sun JVM disables Win32 file locking

Tue May 14 16:35:00 GMT 2002

Adam Megacz wrote:
>Sorry it took me so long to get around to this.. I've confirmed that
>the Sun JVM (1.4.0) disables Win32 file locking on file descriptors
>that it opens.
>
Can we get rid of the "share" variable now? Looks like it isn't used 
after this patch.
>Can I commit this to the 3.1.1 branch (does it exist yet?)
>
AFAIK the same 3.1 branch will be used for 3.1.1, so its just a matter 
of waiting for 3.1 to be released and then you can commit this. It is 
fine for the mainline now of course.
regards
Bryce.
>Index: java/io/natFileDescriptorWin32.cc
>===================================================================
>RCS file: /cvs/gcc/gcc/libjava/java/io/natFileDescriptorWin32.cc,v
>retrieving revision 1.5.2.2
>diff -u -r1.5.2.2 natFileDescriptorWin32.cc
>--- java/io/natFileDescriptorWin32.cc 10 Mar 2002 03:34:59 -0000 1.5.2.2
>+++ java/io/natFileDescriptorWin32.cc 27 Apr 2002 08:40:40 -0000
>@@ -112,7 +112,7 @@
> create = CREATE_ALWAYS;
> }
>>- handle = CreateFile(buf, access, share, NULL, create, 0, NULL);
>+ handle = CreateFile(buf, access, FILE_SHARE_READ | FILE_SHARE_WRITE, NULL, create, 0, NULL);
>> if (handle == INVALID_HANDLE_VALUE)
> {
>>>>