Problem with main routine during linking
Bryce McKinlay
bryce@albatross.co.nz
Tue May 8 06:13:00 GMT 2001
Per Bothner wrote:
>Martin Kahlert <martin.kahlert@infineon.com> writes:
>>>I tried your patch and it works for me, but i do not consider this patch
>>a nice one; it's some kind of a quick hack:
>>>>- it makes internal variables of the general build process public just for
>> one specific language
>>>Nothing wrong with that. The functions lang_specific_driver and
>lang_specific_pre_link are nothing more than hooks to deal with
>specific languages. I just added some more hooks by making two static
>variables public.
>My concern with this approach was also that by exposing more "internals"
of the driver to language specific parts, we realy ain't helping its
complexity any. If for example someone were to make a change to
something dealing with outfiles[], then its more likely they would break
Java since isn't obvious that anything outside gcc.c should be
manipulating it. I suppose that removing the static keyword from these
variables implies that they are no longer "private", but still, it is
increasing complexity (and we know it doesnt need any more of that).
Don't consider this an argument against the patch though - I don't see a
better solution without significant changes to the driver, which
definatly wouldn't be acceptable for the branch, or putting main() in
libgcj (which could cause other problems).
regards
[ bryce ]
More information about the Java
mailing list