Integrating Win32 changes
Tom Tromey
tromey@cygnus.com
Sat Apr 1 00:00:00 GMT 2000
>>>>> "Jon" == Jon Beniston <jb7216@bristol.ac.uk> writes:
Jon> Also, for native files where just a few changes are needed, such
Jon> as prims.cc, I'm putting #ifdef __MINGW32__ around the platform
Jon> specific code. Is that cool? Where a lot of changes have to be
Jon> made I'm implementing them in a new file.
It really depends.
In some situations it might be better to rename files and have
completely new implementations for new OS "flavor" ports (eg, Windows
-vs - POSIX) just like we do for natFileDescriptor.
This is particularly desirable when the code in question already has a
lot of preprocessor stuff in it -- at some point splitting it up is
just cleaner.
Tom
More information about the Java
mailing list