Integrating Win32 changes

Sat Apr 1 00:00:00 GMT 2000

> Jon Beniston wrote:
> > First up, you can't do new FileDescriptor(0) for setting up the standard
i/o
> > streams (as is done in java/io/FileDescriptor), should I have a new file
> > Win32FileDescriptor.java or would it be best to implement a native
function
> > such as FileDescriptor::getStdHandle(int) for all ports.
>> My impression is that FileDescriptor.java is portable enough, except for
> the in/out/err initializers. A new native method should be OK, though
> the name "getStdHandle" sounds too Windows-ish for my taste...
>> > Also, for native files where just a few changes are needed, such as
> > prims.cc, I'm putting #ifdef __MINGW32__ around the platform specific
code.
> > Is that cool? Where a lot of changes have to be made I'm implementing
them
> > in a new file.
>> "#ifdef WIN32" would probably be better unless the code really depends
> on Mingw32. That'll benefit those who may be compiling with Cygwin or
> U/WIN, or other GCC-on-Windows environments.

I think its best not to mix treat ming and cygwin the same. With cygwin you
can
use many of the posix type functions, but you cant with ming. IMHO, building
for cygwin would link to natFileDescriptorPosix.cc whereas a Ming build
would map to natFileDescriptorWin32.cc, for example.