Integrating Win32 changes
Per Bothner
per@bothner.com
Sat Apr 1 00:00:00 GMT 2000
Jeff Sturm <jsturm@sigma6.com> writes:
> "#ifdef WIN32" would probably be better unless the code really depends
> on Mingw32. That'll benefit those who may be compiling with Cygwin or
> U/WIN, or other GCC-on-Windows environments.
Remember that as a general rule we want to avoid conditional
compilation using conditionals that test for specific hosts. Instead,
we want to use conditionals that test for specific *features*. For
example, when it comes to FileDescriptor, we don't want to test for
WIN32 or Mingw32, but for something more specific that identifies the
API. After all, you might want to use Posix-style I/O on WIN32 (e.g.
if you're running CygWin32), so #ifdef WIN32 would do the wrong thing.
--
--Per Bothner
per@bothner.com http://www.bothner.com/~per/
More information about the Java
mailing list