Return to Revisions

There are two ideas mixed together that complicate the code:

• Manipulating an image.
• Uploading an image.

Separate the concerns into two different classes (e.g., SimpleImage and SecureImageUpload).

See the SimpleImage class for a reasonably designed class that handles image manipulation. It has methods to resize, scale, load, and save image files of various formats. I'd recommend that you extend the SimpleImage class to include methods that expose the extra functionality you desire.

Encapsulation means that object data is manipulated by exposing methods to other objects. For example:

$image->load( "filename.jpg" );
$image->scale( 100 );
$image->save( "thumbnails/filename.jpg" );

Securely handling image file uploads in PHP is a daunting task to do correctly. See:

• https://security.stackexchange.com/questions/32852/risks-of-a-php-image-upload-form
• https://stackoverflow.com/questions/4166762/php-image-upload-security-check-list
• http://nullcandy.com/php-image-upload-security-how-not-to-do-it/
• http://www.net-security.org/dl/articles/php-file-upload.pdf
• http://software-security.sans.org/blog/2009/12/28/8-basic-rules-to-implement-secure-file-uploads/