Refactor ruby each-code

Question

def users_list 
 html = '' 
 self.users.each do |user| 
 html << user.link_avatar_tag 
 end 
 html.html_safe 
end 

I feel that it is possible to write shorter.

Is it possible get rid of the temporary variable(html)?

• knut: What class is user? html_safe is no standard method for String - What gems are you using? Or in short: Can you provide a MWE? And to answer: It looks ok for me.
• fantgeass: Main topic of my question: Is it possible get rid of the temporary variable(html)?
• tokland: I'll tag this rails, that's where html_safe comes from.
• tokland: one question about self.users, is this a model? a helper?
• fantgeass: This is TaskDecorator. Task has_and_belongs_to_many :users github.com/drapergem/draper

Answer 1

You should use map (don't use each to accumulate. Check this page about functional programming):

def users_list 
 users.map(&:link_avatar_get).join.html_safe
end

• fantgeass: I change code a bit & that works: self.users.map(&:link_avatar_tag).join.html_safe
• tokland: mmm, yes, you are right, here safe_join is not necessary, edited.