Return to Answer

• Uppercase variable names like N do not follow Java conventions, which is camelCase.

• N, s and str aren't too descriptive names. I'd name them number, strings and string.

• I'd simplify:

   String line = br.readLine();
   int N = Integer.parseInt(line);
  

to:

 int number = Integer.parseInt(br.readLine());

• I'd not create StringBuilder sb = new StringBuilder(s[j]), which is expensive, inside loops but outside and use Java clearing the string buffer after loop.

• Uppercase variable names like N do not follow Java conventions, which is camelCase.

• N, s and str aren't too descriptive names. I'd name them number, strings and string.

• I'd simplify:

   String line = br.readLine();
   int N = Integer.parseInt(line);
  

to:

 int number = Integer.parseInt(br.readLine());

• I'd not create StringBuilder sb = new StringBuilder(s[j]), which is expensive, inside loops but outside and use Java clearing the string buffer after loop.

• Uppercase variable names like N do not follow Java conventions, which is camelCase.

• N, s and str aren't too descriptive names. I'd name them number, strings and string.

• I'd simplify:

   String line = br.readLine();
   int N = Integer.parseInt(line);
  

to:

 int number = Integer.parseInt(br.readLine());

• I'd not create StringBuilder sb = new StringBuilder(s[j]), which is expensive, inside loops but outside and use Java clearing the string buffer after loop.

• Uppercase variable names like N do not follow Java conventions, which is camelCase.

• N, s and str aren't too descriptive names. I'd name them number, strings and string.

• I'd simplify:

   String line = br.readLine();
   int N = Integer.parseInt(line);
  

to:

 int number = Integer.parseInt(br.readLine());

• I'd not create StringBuilder sb = new StringBuilder(s[j]), which is expensive, inside loops but outside and use Java clearing the string buffer after loop.

• Uppercase variable names like N do not follow Java conventions, which is camelCase.

• N, s and str aren't too descriptive names. I'd name them number, lines and line.

• I'd simplify:

   String line = br.readLine();
   int N = Integer.parseInt(line);
  

to

 int number = Integer.parseInt(br.readLine());

• I'd not create StringBuilder sb = new StringBuilder(s[j]), which is expensive, inside loops but outside and use Java clearing the string buffer after loop.

• Uppercase variable names like N do not follow Java conventions, which is camelCase.

• N, s and str aren't too descriptive names. I'd name them number, strings and string.

• I'd simplify:

   String line = br.readLine();
   int N = Integer.parseInt(line);
  

to:

 int number = Integer.parseInt(br.readLine());

• I'd not create StringBuilder sb = new StringBuilder(s[j]), which is expensive, inside loops but outside and use Java clearing the string buffer after loop.