Skip to main content
Code Review

Return to Answer

Commonmark migration
Source Link

Just a quick nitpick, but it could help if you need to debug

if (numberAboveMiddle <= 0)
 throw new ArgumentOutOfRangeException("numberAboveMiddle", numberAboveMiddle, "The parameter numberAboveMiddle must be greater than 0."); 
if (numberBelowMiddle <= 0)
 throw new ArgumentOutOfRangeException("numberAboveMiddle", numberBelowMiddle, "The parameter numberBelowMiddle must be greater than 0.");

the parameter name in the second ArgumentOutOfRangeException should be "numberBelowMiddle".

Just a quick nitpick, but it could help if you need to debug

if (numberAboveMiddle <= 0)
 throw new ArgumentOutOfRangeException("numberAboveMiddle", numberAboveMiddle, "The parameter numberAboveMiddle must be greater than 0."); 
if (numberBelowMiddle <= 0)
 throw new ArgumentOutOfRangeException("numberAboveMiddle", numberBelowMiddle, "The parameter numberBelowMiddle must be greater than 0.");

the parameter name in the second ArgumentOutOfRangeException should be "numberBelowMiddle".

Just a quick nitpick, but it could help if you need to debug

if (numberAboveMiddle <= 0)
 throw new ArgumentOutOfRangeException("numberAboveMiddle", numberAboveMiddle, "The parameter numberAboveMiddle must be greater than 0."); 
if (numberBelowMiddle <= 0)
 throw new ArgumentOutOfRangeException("numberAboveMiddle", numberBelowMiddle, "The parameter numberBelowMiddle must be greater than 0.");

the parameter name in the second ArgumentOutOfRangeException should be "numberBelowMiddle".

fixed code snippet
Source Link
Quill
  • 12k
  • 5
  • 41
  • 93

Just a quick nitpick, but it could help if you need to debug

if (numberAboveMiddle <= 0)
 throw new ArgumentOutOfRangeException("numberAboveMiddle", numberAboveMiddle, "The parameter numberAboveMiddle must be greater than 0."); 
if (numberBelowMiddle <= 0)
 throw new ArgumentOutOfRangeException("numberAboveMiddle", numberBelowMiddle, "The parameter numberBelowMiddle must be greater than 0.");

the parameter name in the second ArgumentOutOfRangeException should be "numberBelowMiddle""numberBelowMiddle".

Just a quick nitpick, but it could help if you need to debug

if (numberAboveMiddle <= 0)
 throw new ArgumentOutOfRangeException("numberAboveMiddle", numberAboveMiddle, "The parameter numberAboveMiddle must be greater than 0."); 
if (numberBelowMiddle <= 0)
 throw new ArgumentOutOfRangeException("numberAboveMiddle", numberBelowMiddle, "The parameter numberBelowMiddle must be greater than 0.");

the parameter name in the second ArgumentOutOfRangeException should be "numberBelowMiddle".

Just a quick nitpick, but it could help if you need to debug

if (numberAboveMiddle <= 0)
 throw new ArgumentOutOfRangeException("numberAboveMiddle", numberAboveMiddle, "The parameter numberAboveMiddle must be greater than 0."); 
if (numberBelowMiddle <= 0)
 throw new ArgumentOutOfRangeException("numberAboveMiddle", numberBelowMiddle, "The parameter numberBelowMiddle must be greater than 0.");

the parameter name in the second ArgumentOutOfRangeException should be "numberBelowMiddle".

Source Link
Heslacher
  • 50.9k
  • 5
  • 83
  • 177

Just a quick nitpick, but it could help if you need to debug

if (numberAboveMiddle <= 0)
 throw new ArgumentOutOfRangeException("numberAboveMiddle", numberAboveMiddle, "The parameter numberAboveMiddle must be greater than 0."); 
if (numberBelowMiddle <= 0)
 throw new ArgumentOutOfRangeException("numberAboveMiddle", numberBelowMiddle, "The parameter numberBelowMiddle must be greater than 0.");

the parameter name in the second ArgumentOutOfRangeException should be "numberBelowMiddle".

lang-cs

AltStyle によって変換されたページ (->オリジナル) /