Return to Answer

replaced http://stackoverflow.com/ with https://stackoverflow.com/

edited May 23, 2017 at 12:40

edited May 23, 2017 at 12:40

The randomize method is an overridable method and you calling it from the constructor, which is quite dangerous in Java. Methods which you call from the constructor shouldn't be overridable, i.e.: private or final or static. Check this out Check this out.
The precondition in the compute method would throw an exception if the input is null, so you can add an additional guard for that:
```
 Preconditions.checkNotNull(inputs);
```
At #Layer(neurons,prevLayerNeurons), you're creating arrays based on the passed arguments. Are sure that the passed arguments are valid as an array length? Why don't you protect it?
```
 Preconditions.checkArgument(neurons > 0);
 Preconditions.checkArgument(prevLayerNeurons > 0);
```

The randomize method is an overridable method and you calling it from the constructor, which is quite dangerous in Java. Methods which you call from the constructor shouldn't be overridable, i.e.: private or final or static. Check this out.
The precondition in the compute method would throw an exception if the input is null, so you can add an additional guard for that:
```
 Preconditions.checkNotNull(inputs);
```
At #Layer(neurons,prevLayerNeurons), you're creating arrays based on the passed arguments. Are sure that the passed arguments are valid as an array length? Why don't you protect it?
```
 Preconditions.checkArgument(neurons > 0);
 Preconditions.checkArgument(prevLayerNeurons > 0);
```

The randomize method is an overridable method and you calling it from the constructor, which is quite dangerous in Java. Methods which you call from the constructor shouldn't be overridable, i.e.: private or final or static. Check this out.
The precondition in the compute method would throw an exception if the input is null, so you can add an additional guard for that:
```
 Preconditions.checkNotNull(inputs);
```
At #Layer(neurons,prevLayerNeurons), you're creating arrays based on the passed arguments. Are sure that the passed arguments are valid as an array length? Why don't you protect it?
```
 Preconditions.checkArgument(neurons > 0);
 Preconditions.checkArgument(prevLayerNeurons > 0);
```

deleted 12 characters in body

edited Oct 24, 2015 at 23:37

edited Oct 24, 2015 at 23:37

The randomize method is an overridable method and you calling formit from the constructor, and thatswhich is quite dangerous in JavaJava. Methods which you call from the constructor shouldn't be overridable, iei.e.: private or final or static. Check this out.
The Preconditionprecondition in the compute method would throw an exception if the input is nullnull, so you can add andan additional guard for that.:
```
Preconditions.checkNotNull(inputs);
```
At #Layer(neurons,prevLayerNeurons), you're creating arrays based on the passed arguments. Are sure that the passed arguments are valid as an array length? Why don't you protect it?
```
 Preconditions.checkArgument(neurons > 0);
 Preconditions.checkArgument(prevLayerNeurons > 0);
```

At #Layer(neurons,prevLayerNeurons) you creating arrays based on the passed arguments, are sure that the passed arguments are valid as an array length?Why don't you protect it
```
Preconditions.checkArgument(neurons > 0);
Preconditions.checkArgument(prevLayerNeurons > 0);
```

randomize method is an overridable method and you calling form the constructor, and thats quite dangerous in Java. Methods which you call from the constructor shouldn't be overridable, ie: private or final or static. Check this out.
The Precondition in the compute method would throw an exception if the input is null, you can add and additional guard for that.
```
Preconditions.checkNotNull(inputs);
```

At #Layer(neurons,prevLayerNeurons) you creating arrays based on the passed arguments, are sure that the passed arguments are valid as an array length?Why don't you protect it
```
Preconditions.checkArgument(neurons > 0);
Preconditions.checkArgument(prevLayerNeurons > 0);
```

The randomize method is an overridable method and you calling it from the constructor, which is quite dangerous in Java. Methods which you call from the constructor shouldn't be overridable, i.e.: private or final or static. Check this out.
The precondition in the compute method would throw an exception if the input is null, so you can add an additional guard for that:
```
Preconditions.checkNotNull(inputs);
```
At #Layer(neurons,prevLayerNeurons), you're creating arrays based on the passed arguments. Are sure that the passed arguments are valid as an array length? Why don't you protect it?
```
 Preconditions.checkArgument(neurons > 0);
 Preconditions.checkArgument(prevLayerNeurons > 0);
```

added 314 characters in body

edited Jun 11, 2015 at 11:33

edited Jun 11, 2015 at 11:33

randomize method is an overridable method and you calling form the constructor, and thats quite dangerous in Java. Methods which you call from the constructor shouldn't be overridable, ie: private or final or static. Check this out.
The Precondition in the compute method would throw an exception if the input is null, you can add and additional guard for that.
```
Preconditions.checkNotNull(inputs);
```

At #Layer(neurons,prevLayerNeurons) you creating arrays based on the passed arguments, are sure that the passed arguments are valid as an array length?Why don't you protect it
```
Preconditions.checkArgument(neurons > 0);
Preconditions.checkArgument(prevLayerNeurons > 0);
```

randomize method is an overridable method and you calling form the constructor, and thats quite dangerous in Java. Methods which you call from the constructor shouldn't be overridable, ie: private or final or static. Check this out.
The Precondition in the compute method would throw an exception if the input is null, you can add and additional guard for that.
```
Preconditions.checkNotNull(inputs);
```

randomize method is an overridable method and you calling form the constructor, and thats quite dangerous in Java. Methods which you call from the constructor shouldn't be overridable, ie: private or final or static. Check this out.
The Precondition in the compute method would throw an exception if the input is null, you can add and additional guard for that.
```
Preconditions.checkNotNull(inputs);
```

At #Layer(neurons,prevLayerNeurons) you creating arrays based on the passed arguments, are sure that the passed arguments are valid as an array length?Why don't you protect it
```
Preconditions.checkArgument(neurons > 0);
Preconditions.checkArgument(prevLayerNeurons > 0);
```

answered Jun 11, 2015 at 11:27

answered Jun 11, 2015 at 11:27

lang-java