Skip to main content
Code Review

Return to Answer

replaced http://programmers.stackexchange.com/ with https://softwareengineering.stackexchange.com/
Source Link

It just doesn't smell good. Maybe you should post more code. This kind of searches looks weird to me.

Anyway, the User class should have a getProjNameById(final int id) method, the Session class should have getTransactionNameByTransactionTypeId(final int id) and getCurrencyTypeNameByCurrencyTypeId(final int id) methods as well. It would result higher cohesion and easier maintenance.

Note that the Singleton pattern is an antipattern nowadays. (The Singleton Pattern The Singleton Pattern)

It just doesn't smell good. Maybe you should post more code. This kind of searches looks weird to me.

Anyway, the User class should have a getProjNameById(final int id) method, the Session class should have getTransactionNameByTransactionTypeId(final int id) and getCurrencyTypeNameByCurrencyTypeId(final int id) methods as well. It would result higher cohesion and easier maintenance.

Note that the Singleton pattern is an antipattern nowadays. (The Singleton Pattern)

It just doesn't smell good. Maybe you should post more code. This kind of searches looks weird to me.

Anyway, the User class should have a getProjNameById(final int id) method, the Session class should have getTransactionNameByTransactionTypeId(final int id) and getCurrencyTypeNameByCurrencyTypeId(final int id) methods as well. It would result higher cohesion and easier maintenance.

Note that the Singleton pattern is an antipattern nowadays. (The Singleton Pattern)

It just doesn't smellsmell good. Maybe you should post more code. This kind of searches looks weird to me.

Anyway, the User class should have a getProjNameById(final int id) method, the Session class should have getTransactionNameByTransactionTypeId(final int id) and getCurrencyTypeNameByCurrencyTypeId(final int id) methods as well. It would result higher cohesion and easier maintenance.

Note that the Singleton pattern is an antipattern nowadays. (The Singleton Pattern)

It just doesn't smell good. Maybe you should post more code. This kind of searches looks weird to me.

Anyway, the User class should have a getProjNameById(final int id) method, the Session class should have getTransactionNameByTransactionTypeId(final int id) and getCurrencyTypeNameByCurrencyTypeId(final int id) methods as well. It would result higher cohesion and easier maintenance.

Note that the Singleton pattern is an antipattern nowadays. (The Singleton Pattern)

It just doesn't smell good. Maybe you should post more code. This kind of searches looks weird to me.

Anyway, the User class should have a getProjNameById(final int id) method, the Session class should have getTransactionNameByTransactionTypeId(final int id) and getCurrencyTypeNameByCurrencyTypeId(final int id) methods as well. It would result higher cohesion and easier maintenance.

Note that the Singleton pattern is an antipattern nowadays. (The Singleton Pattern)

removed abbreviations
Source Link
palacsint
  • 30.4k
  • 9
  • 82
  • 157

It just doesn't smell good. Maybe you should post more code. This kind of searches looks weird to me.

Anyway, the User class should have a getProjNmByIdgetProjNameById(final int id) method, the Session class should have getTransactionNmByTransactionTypeIdgetTransactionNameByTransactionTypeId(final int id) and getCurrencyTypeNmByCurrencyTypeIdgetCurrencyTypeNameByCurrencyTypeId(final int id) methods as well. It would result higher cohesion and easier maintenance.

Note that the Singleton pattern is an antipattern nowadays. (The Singleton Pattern)

It just doesn't smell good. Maybe you should post more code. This kind of searches looks weird to me.

Anyway, the User class should have a getProjNmById(int id) method, the Session class should have getTransactionNmByTransactionTypeId(int id) and getCurrencyTypeNmByCurrencyTypeId(int id) methods as well. It would result higher cohesion and easier maintenance.

Note that the Singleton pattern is an antipattern nowadays. (The Singleton Pattern)

It just doesn't smell good. Maybe you should post more code. This kind of searches looks weird to me.

Anyway, the User class should have a getProjNameById(final int id) method, the Session class should have getTransactionNameByTransactionTypeId(final int id) and getCurrencyTypeNameByCurrencyTypeId(final int id) methods as well. It would result higher cohesion and easier maintenance.

Note that the Singleton pattern is an antipattern nowadays. (The Singleton Pattern)

Source Link
palacsint
  • 30.4k
  • 9
  • 82
  • 157
Loading
lang-java

AltStyle によって変換されたページ (->オリジナル) /