Skip to main content
Code Review

Return to Answer

Commonmark migration
Source Link

The answer of rolfl should be the accepted one. It handles nearly everything. I just want to add some remarks:

Bugs

#Bugs IfIf none of the $_POST variables are set. Something will break...

Security

#Security YourYour password generator is not secure.

Shuffle internally uses the same 'randomness' as rand(). More info here. This means that your 'random' password is not random when talking security. It will seem random for the human eye, but a computer will quickly burst that bubble.

A much better an easier way of generating a random password is using openssl_random_pseudo_bytes.

The answer of rolfl should be the accepted one. It handles nearly everything. I just want to add some remarks:

#Bugs If none of the $_POST variables are set. Something will break...

#Security Your password generator is not secure.

Shuffle internally uses the same 'randomness' as rand(). More info here. This means that your 'random' password is not random when talking security. It will seem random for the human eye, but a computer will quickly burst that bubble.

A much better an easier way of generating a random password is using openssl_random_pseudo_bytes.

The answer of rolfl should be the accepted one. It handles nearly everything. I just want to add some remarks:

Bugs

If none of the $_POST variables are set. Something will break...

Security

Your password generator is not secure.

Shuffle internally uses the same 'randomness' as rand(). More info here. This means that your 'random' password is not random when talking security. It will seem random for the human eye, but a computer will quickly burst that bubble.

A much better an easier way of generating a random password is using openssl_random_pseudo_bytes.

replaced http://stackoverflow.com/ with https://stackoverflow.com/
Source Link

The answer of rolfl should be the accepted one. It handles nearly everything. I just want to add some remarks:

#Bugs If none of the $_POST variables are set. Something will break...

#Security Your password generator is not secure.

Shuffle internally uses the same 'randomness' as rand(). More info here here. This means that your 'random' password is not random when talking security. It will seem random for the human eye, but a computer will quickly burst that bubble.

A much better an easier way of generating a random password is using openssl_random_pseudo_bytes.

The answer of rolfl should be the accepted one. It handles nearly everything. I just want to add some remarks:

#Bugs If none of the $_POST variables are set. Something will break...

#Security Your password generator is not secure.

Shuffle internally uses the same 'randomness' as rand(). More info here. This means that your 'random' password is not random when talking security. It will seem random for the human eye, but a computer will quickly burst that bubble.

A much better an easier way of generating a random password is using openssl_random_pseudo_bytes.

The answer of rolfl should be the accepted one. It handles nearly everything. I just want to add some remarks:

#Bugs If none of the $_POST variables are set. Something will break...

#Security Your password generator is not secure.

Shuffle internally uses the same 'randomness' as rand(). More info here. This means that your 'random' password is not random when talking security. It will seem random for the human eye, but a computer will quickly burst that bubble.

A much better an easier way of generating a random password is using openssl_random_pseudo_bytes.

typo fixes
Source Link
Pimgd
  • 22.5k
  • 5
  • 68
  • 144

The answer of rolfl shoulwshould be the acecptedaccepted one. It handles nearly everything. I just want to add some remarks:

#Bugs If nonnone of the $_POST$_POST variables are set. Something will break...

#Security Your password generator is not secure.

Shuffle internally uses the same 'randomness' as rand(). More info here. This means that your 'random' password is not random when talking security. It will seem random for the human eye, but a computer will quickly burst that bubble.

A much better an easier way of generating a random password is using openssl_random_pseudo_bytes.

The answer of rolfl shoulw be the acecpted one. It handles nearly everything. I just want to add some remarks:

#Bugs If non of the $_POST variables are set. Something will break...

#Security Your password generator is not secure.

Shuffle internally uses the same 'randomness' as rand(). More info here. This means that your 'random' password is not random when talking security. It will seem random for the human eye, but a computer will quickly burst that bubble.

A much better an easier way of generating a random password is using openssl_random_pseudo_bytes.

The answer of rolfl should be the accepted one. It handles nearly everything. I just want to add some remarks:

#Bugs If none of the $_POST variables are set. Something will break...

#Security Your password generator is not secure.

Shuffle internally uses the same 'randomness' as rand(). More info here. This means that your 'random' password is not random when talking security. It will seem random for the human eye, but a computer will quickly burst that bubble.

A much better an easier way of generating a random password is using openssl_random_pseudo_bytes.

Source Link
Pinoniq
  • 3k
  • 13
  • 17
Loading
lang-php

AltStyle によって変換されたページ (->オリジナル) /