Skip to main content
Code Review

Return to Answer

replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
Source Link

You completely ignored the first points from the review your earlier question the review your earlier question, and they still apply here:

You completely ignored the first points from the review your earlier question, and they still apply here:

You completely ignored the first points from the review your earlier question, and they still apply here:

Bounty Awarded with 50 reputation awarded by rolfl
added 23 characters in body
Source Link
janos
  • 112.9k
  • 15
  • 154
  • 396

I would say trygo even further, and recommend to stay within 70 chars. Look at this for example:

I would say try to stay within 70 chars. Look at this for example:

I would go even further, and recommend to stay within 70 chars. Look at this for example:

edited body
Source Link
janos
  • 112.9k
  • 15
  • 154
  • 396

Functions

According to the bash hackers wiki , this writing style of function declarations is not recommended:

function Play {
 # ...
}

This is the preferred way:

Play() {
 # ...
}

Simplifications

Functions

According to the bash hackers wiki , this writing style of function declarations is not recommended:

function Play {
 # ...
}

This is the preferred way:

Play() {
 # ...
}

Functions

According to the bash hackers wiki , this writing style of function declarations is not recommended:

function Play {
 # ...
}

This is the preferred way:

Play() {
 # ...
}

Simplifications

Simplifications

Functions

According to the bash hackers wiki , this writing style of function declarations is not recommended:

function Play {
 # ...
}

This is the preferred way:

Play() {
 # ...
}
Source Link
janos
  • 112.9k
  • 15
  • 154
  • 396
Loading
lang-bash

AltStyle によって変換されたページ (->オリジナル) /