Skip to main content
Code Review

Return to Answer

replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
Source Link

(Thank you @pbk1303 @pbk1303, excellent point & link!)

@Ben @Ben left an excellent remark in comments:

(Thank you @pbk1303, excellent point & link!)

@Ben left an excellent remark in comments:

(Thank you @pbk1303, excellent point & link!)

@Ben left an excellent remark in comments:

added 466 characters in body
Source Link
janos
  • 112.9k
  • 15
  • 154
  • 396

Inlining CSS with npm juice

@Ben left an excellent remark in comments:

Might also be worth mentioning that you can install juice with npm, to be able to inline the CSS from an external file; that way you keep all the benefits of separate CSS whilst still being able to generate an email client friendly version. npmjs.org/package/juice

Inlining CSS with npm juice

@Ben left an excellent remark in comments:

Might also be worth mentioning that you can install juice with npm, to be able to inline the CSS from an external file; that way you keep all the benefits of separate CSS whilst still being able to generate an email client friendly version. npmjs.org/package/juice

added 215 characters in body
Source Link
janos
  • 112.9k
  • 15
  • 154
  • 396

... while this is legal (I think), nested tables are usually a bad idea. Consider using Bootstrap from Twitter .

The whole point of CSS is to separate the fine-tuned styling from(削除) The whole point of CSS is to separate the fine-tuned styling from the HTML. You really shouldn't inline so many style attributes everywhere. Move the content of all those inlined style declarations to a separate .css file. You will be able to reduce a lot of the duplication, and you will get a much more maintainable solution: you will be able to make style changes in one place and they will apply in all the places where that style should be used. (削除ここまで)

UPDATE: the original post did not mention that this HTML. You really shouldn't inline so many style attributes everywhere. Move the content of all those inlined style declarations to a separate .css file. You will be able is to reduce a lot of the duplication, and you will get a much more maintainable solution: you will be able to make style changesused in one place and they will applyan email, that bit was added later. And in all the places where that style shouldcase, inline CSS can be used.acceptable:

http://css-tricks.com/using-css-in-html-emails-the-real-story/

(Thank you @pbk1303 , excellent point & link!)

... while this is legal (I think), nested tables are usually a bad idea. Consider using Bootstrap from Twitter .

The whole point of CSS is to separate the fine-tuned styling from the HTML. You really shouldn't inline so many style attributes everywhere. Move the content of all those inlined style declarations to a separate .css file. You will be able to reduce a lot of the duplication, and you will get a much more maintainable solution: you will be able to make style changes in one place and they will apply in all the places where that style should be used.

(削除) The whole point of CSS is to separate the fine-tuned styling from the HTML. You really shouldn't inline so many style attributes everywhere. Move the content of all those inlined style declarations to a separate .css file. You will be able to reduce a lot of the duplication, and you will get a much more maintainable solution: you will be able to make style changes in one place and they will apply in all the places where that style should be used. (削除ここまで)

UPDATE: the original post did not mention that this HTML is to be used in an email, that bit was added later. And in that case, inline CSS can be acceptable:

http://css-tricks.com/using-css-in-html-emails-the-real-story/

(Thank you @pbk1303 , excellent point & link!)

added 400 characters in body
Source Link
janos
  • 112.9k
  • 15
  • 154
  • 396
Loading
Source Link
janos
  • 112.9k
  • 15
  • 154
  • 396
Loading
lang-css

AltStyle によって変換されたページ (->オリジナル) /