Skip to main content
Code Review

Return to Answer

replaced http://stackoverflow.com/ with https://stackoverflow.com/
Source Link
replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
Source Link

You have some phpDoc comments, you need one for every function. But please note that I've been accused accused of overcommenting :)

PS. You should remove ?> from the end of every class script, as leo suggests suggests.

You have some phpDoc comments, you need one for every function. But please note that I've been accused of overcommenting :)

PS. You should remove ?> from the end of every class script, as leo suggests.

You have some phpDoc comments, you need one for every function. But please note that I've been accused of overcommenting :)

PS. You should remove ?> from the end of every class script, as leo suggests.

Bounty Awarded with 100 reputation awarded by Naftali
added PHP4 style class members section
Source Link
yannis
  • 2.1k
  • 1
  • 19
  • 38

you could help the IDE by adding the public keyword. That's also a readibillity point and a PHP4 style (function foo()) vs PHP5 style (public function foo()).

You have some phpDoc comments, you need one for every function. But please note that I've been accused of overcommenting :)

PHP4 style class members

You are using some PHP4 style class members:

var $name = __CLASS__;
var $helpers = array();
var $validate = array();
var $posts = array();

You should be using PHP5 access control (public / private / protected) members everywhere.

you could help the IDE by adding the public keyword. That's also a readibillity point.

You have some phpDoc comments, you need one for every function. But please note that I've been accused of overcommenting :)

you could help the IDE by adding the public keyword. That's also a readibillity point and a PHP4 style (function foo()) vs PHP5 style (public function foo()).

You have some phpDoc comments, you need one for every function. But please note that I've been accused of overcommenting :)

PHP4 style class members

You are using some PHP4 style class members:

var $name = __CLASS__;
var $helpers = array();
var $validate = array();
var $posts = array();

You should be using PHP5 access control (public / private / protected) members everywhere.

added 160 characters in body
Source Link
yannis
  • 2.1k
  • 1
  • 19
  • 38
Loading
Source Link
yannis
  • 2.1k
  • 1
  • 19
  • 38
Loading
lang-php

AltStyle によって変換されたページ (->オリジナル) /