Return to Answer

replaced http://stackoverflow.com/ with https://stackoverflow.com/

edited May 23, 2017 at 12:40

The flat namespaces seem a little weird to me, but the answers to this question this question and this question this question offer mixed suggestions on the preferred usage. They also seem to suggest that you may not need more than two namespaces, but I'm not familiar enough with this design to know for sure.
Some of your comments are unnecessary, such as this one:
```
// Forward Declarations
```
It's already pretty clear that this is a forward declaration, and you don't need to tell us anyway. Comments should best be used to document something unobvious for others.
In some places you do this:
```
protected: 
private:
 // code here...
```
and in other places you do this:
```
private:
 // no code here...
```
If you don't currently have anything after such a keyword, simply leave it out. Keeping them there anyway doesn't really help with maintenance, and can still leave others confused about why it's left there anyway. It's especially unneeded for private, as classes are private by default. It is okay (usually preferred) to keep the keyword there anyway, but it should still have some code.

Side-note: as @Laurent has mentioned, there's not much to review here as all you've given us are headers. On the other hand, there's already much code here, so any additional code for review should be posted as a separate question.

The flat namespaces seem a little weird to me, but the answers to this question and this question offer mixed suggestions on the preferred usage. They also seem to suggest that you may not need more than two namespaces, but I'm not familiar enough with this design to know for sure.
Some of your comments are unnecessary, such as this one:
```
// Forward Declarations
```
It's already pretty clear that this is a forward declaration, and you don't need to tell us anyway. Comments should best be used to document something unobvious for others.
In some places you do this:
```
protected: 
private:
 // code here...
```
and in other places you do this:
```
private:
 // no code here...
```
If you don't currently have anything after such a keyword, simply leave it out. Keeping them there anyway doesn't really help with maintenance, and can still leave others confused about why it's left there anyway. It's especially unneeded for private, as classes are private by default. It is okay (usually preferred) to keep the keyword there anyway, but it should still have some code.

The flat namespaces seem a little weird to me, but the answers to this question and this question offer mixed suggestions on the preferred usage. They also seem to suggest that you may not need more than two namespaces, but I'm not familiar enough with this design to know for sure.
Some of your comments are unnecessary, such as this one:
```
// Forward Declarations
```
It's already pretty clear that this is a forward declaration, and you don't need to tell us anyway. Comments should best be used to document something unobvious for others.
In some places you do this:
```
protected: 
private:
 // code here...
```
and in other places you do this:
```
private:
 // no code here...
```
If you don't currently have anything after such a keyword, simply leave it out. Keeping them there anyway doesn't really help with maintenance, and can still leave others confused about why it's left there anyway. It's especially unneeded for private, as classes are private by default. It is okay (usually preferred) to keep the keyword there anyway, but it should still have some code.

Source Link

answered Jul 15, 2014 at 23:39

Jamal

answered Jul 15, 2014 at 23:39

Jamal

35.2k
13
134
238

The flat namespaces seem a little weird to me, but the answers to this question and this question offer mixed suggestions on the preferred usage. They also seem to suggest that you may not need more than two namespaces, but I'm not familiar enough with this design to know for sure.
Some of your comments are unnecessary, such as this one:
```
// Forward Declarations
```
It's already pretty clear that this is a forward declaration, and you don't need to tell us anyway. Comments should best be used to document something unobvious for others.
In some places you do this:
```
protected: 
private:
 // code here...
```
and in other places you do this:
```
private:
 // no code here...
```
If you don't currently have anything after such a keyword, simply leave it out. Keeping them there anyway doesn't really help with maintenance, and can still leave others confused about why it's left there anyway. It's especially unneeded for private, as classes are private by default. It is okay (usually preferred) to keep the keyword there anyway, but it should still have some code.

lang-cpp