Skip to main content
Code Review

Return to Answer

replaced http://stackoverflow.com/ with https://stackoverflow.com/
Source Link

There is still a bunch of // TODO Auto-generated method stub in your code. Those are generated by the IDE and should be remove since it's just noise.

You still have a bunch of e.printStackTrace(); in your some of your catch clause. Those should be replace by a proper logger of the android platform, since as you can read in this question question it simply write to a general log file. As per Simon's comments, you should make sure you're using a tag when you log. This will help filtering the log file. Your logging statement will be like this :

Log.d(MEANINGFUL_TAG, "The message to log");

Be carefull with your indentation/white-space style, this look really weird :

 if (success == 1) {
 Log.d("", "Successfully logged session!");
 } else {
 // failed 
 Log.d("", "Not Successful!");
 }

I'm not an knowledgeable enough in android to see that it's wrong but protected String doInBackground(String... args) should probably be void since you're only returning null at the end of the method. If you don't need to return something, then don't define a return type.

There is still a bunch of // TODO Auto-generated method stub in your code. Those are generated by the IDE and should be remove since it's just noise.

You still have a bunch of e.printStackTrace(); in your some of your catch clause. Those should be replace by a proper logger of the android platform, since as you can read in this question it simply write to a general log file. As per Simon's comments, you should make sure you're using a tag when you log. This will help filtering the log file. Your logging statement will be like this :

Log.d(MEANINGFUL_TAG, "The message to log");

Be carefull with your indentation/white-space style, this look really weird :

 if (success == 1) {
 Log.d("", "Successfully logged session!");
 } else {
 // failed 
 Log.d("", "Not Successful!");
 }

I'm not an knowledgeable enough in android to see that it's wrong but protected String doInBackground(String... args) should probably be void since you're only returning null at the end of the method. If you don't need to return something, then don't define a return type.

There is still a bunch of // TODO Auto-generated method stub in your code. Those are generated by the IDE and should be remove since it's just noise.

You still have a bunch of e.printStackTrace(); in your some of your catch clause. Those should be replace by a proper logger of the android platform, since as you can read in this question it simply write to a general log file. As per Simon's comments, you should make sure you're using a tag when you log. This will help filtering the log file. Your logging statement will be like this :

Log.d(MEANINGFUL_TAG, "The message to log");

Be carefull with your indentation/white-space style, this look really weird :

 if (success == 1) {
 Log.d("", "Successfully logged session!");
 } else {
 // failed 
 Log.d("", "Not Successful!");
 }

I'm not an knowledgeable enough in android to see that it's wrong but protected String doInBackground(String... args) should probably be void since you're only returning null at the end of the method. If you don't need to return something, then don't define a return type.

replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
Source Link

There is still a bunch of // TODO Auto-generated method stub in your code. Those are generated by the IDE and should be remove since it's just noise.

You still have a bunch of e.printStackTrace(); in your some of your catch clause. Those should be replace by a proper logger of the android platform, since as you can read in this question it simply write to a general log file. As per Simon's comments comments, you should make sure you're using a tag when you log. This will help filtering the log file. Your logging statement will be like this :

Log.d(MEANINGFUL_TAG, "The message to log");

Be carefull with your indentation/white-space style, this look really weird :

 if (success == 1) {
 Log.d("", "Successfully logged session!");
 } else {
 // failed 
 Log.d("", "Not Successful!");
 }

I'm not an knowledgeable enough in android to see that it's wrong but protected String doInBackground(String... args) should probably be void since you're only returning null at the end of the method. If you don't need to return something, then don't define a return type.

There is still a bunch of // TODO Auto-generated method stub in your code. Those are generated by the IDE and should be remove since it's just noise.

You still have a bunch of e.printStackTrace(); in your some of your catch clause. Those should be replace by a proper logger of the android platform, since as you can read in this question it simply write to a general log file. As per Simon's comments, you should make sure you're using a tag when you log. This will help filtering the log file. Your logging statement will be like this :

Log.d(MEANINGFUL_TAG, "The message to log");

Be carefull with your indentation/white-space style, this look really weird :

 if (success == 1) {
 Log.d("", "Successfully logged session!");
 } else {
 // failed 
 Log.d("", "Not Successful!");
 }

I'm not an knowledgeable enough in android to see that it's wrong but protected String doInBackground(String... args) should probably be void since you're only returning null at the end of the method. If you don't need to return something, then don't define a return type.

There is still a bunch of // TODO Auto-generated method stub in your code. Those are generated by the IDE and should be remove since it's just noise.

You still have a bunch of e.printStackTrace(); in your some of your catch clause. Those should be replace by a proper logger of the android platform, since as you can read in this question it simply write to a general log file. As per Simon's comments, you should make sure you're using a tag when you log. This will help filtering the log file. Your logging statement will be like this :

Log.d(MEANINGFUL_TAG, "The message to log");

Be carefull with your indentation/white-space style, this look really weird :

 if (success == 1) {
 Log.d("", "Successfully logged session!");
 } else {
 // failed 
 Log.d("", "Not Successful!");
 }

I'm not an knowledgeable enough in android to see that it's wrong but protected String doInBackground(String... args) should probably be void since you're only returning null at the end of the method. If you don't need to return something, then don't define a return type.

added suggestion of Simon's comment
Source Link
Marc-Andre
  • 6.8k
  • 5
  • 39
  • 65

There is still a bunch of // TODO Auto-generated method stub in your code. Those are generated by the IDE and should be remove since it's just noise.

You still have a bunch of e.printStackTrace(); in your some of your catch clause. Those should be replace by a proper logger of the android platform, since as you can read in this question it simply write to a general log file. As per Simon's comments , you should make sure you're using a tag when you log. This will help filtering the log file. Your logging statement will be like this :

Log.d(MEANINGFUL_TAG, "The message to log");

Be carefull with your indentation/white-space style, this look really weird :

 if (success == 1) {
 Log.d("", "Successfully logged session!");
 } else {
 // failed 
 Log.d("", "Not Successful!");
 }

I'm not an knowledgeable enough in android to see that it's wrong but protected String doInBackground(String... args) should probably be void since you're only returning null at the end of the method. If you don't need to return something, then don't define a return type.

There is still a bunch of // TODO Auto-generated method stub in your code. Those are generated by the IDE and should be remove since it's just noise.

You still have a bunch of e.printStackTrace(); in your some of your catch clause. Those should be replace by a proper logger of the android platform, since as you can read in this question it simply write to a general log file.

Be carefull with your indentation/white-space style, this look really weird :

 if (success == 1) {
 Log.d("", "Successfully logged session!");
 } else {
 // failed 
 Log.d("", "Not Successful!");
 }

I'm not an knowledgeable enough in android to see that it's wrong but protected String doInBackground(String... args) should probably be void since you're only returning null at the end of the method. If you don't need to return something, then don't define a return type.

There is still a bunch of // TODO Auto-generated method stub in your code. Those are generated by the IDE and should be remove since it's just noise.

You still have a bunch of e.printStackTrace(); in your some of your catch clause. Those should be replace by a proper logger of the android platform, since as you can read in this question it simply write to a general log file. As per Simon's comments , you should make sure you're using a tag when you log. This will help filtering the log file. Your logging statement will be like this :

Log.d(MEANINGFUL_TAG, "The message to log");

Be carefull with your indentation/white-space style, this look really weird :

 if (success == 1) {
 Log.d("", "Successfully logged session!");
 } else {
 // failed 
 Log.d("", "Not Successful!");
 }

I'm not an knowledgeable enough in android to see that it's wrong but protected String doInBackground(String... args) should probably be void since you're only returning null at the end of the method. If you don't need to return something, then don't define a return type.

Source Link
Marc-Andre
  • 6.8k
  • 5
  • 39
  • 65
Loading
lang-java

AltStyle によって変換されたページ (->オリジナル) /