Timeline for Removing duplicate code from basic collision detection implementation
Current License: CC BY-SA 3.0
7 events
when toggle format | what | by | license | comment | |
---|---|---|---|---|---|
Jun 10, 2020 at 13:24 | history | edited | Community Bot |
Commonmark migration
|
|
May 3, 2014 at 14:01 | comment | added | mallardz | Thanks Bruno. I might post this again later on as a new question but first I have much worse code elsewhere in the game to deal with! In the meantime I've accepted your answer as the one that works and doesn't do anything potentially dangerous. | |
May 2, 2014 at 18:46 | comment | added | Bruno Costa | I will be able to review your DeltaManager if you edit your question or make a follow up (which I think that could suit better here). | |
May 2, 2014 at 17:25 | comment | added | mallardz | Dang, every time I think I've fixed something, I seem to introduce even more problems! Thanks for the link, I have vague recollections of this when I read Effective Java (and promptly forgot it). The link suggests that it would fail immediately, but I've been running my code for a bit and the collision detection seems fine. I wonder if it is because I'm not relying on any fields or state in the overridden methods in the constructor, but they are directly passing arguments instead. I also wonder why Eclipse doesn't warn about this, seems easy enough to detect. Ok, back to the drawing board. | |
May 2, 2014 at 16:21 | comment | added | Bruno Costa | You shouldn't call methods that can be overriden in the constructor (or in their code they do so). See why here | |
May 2, 2014 at 16:16 | history | edited | mallardz | CC BY-SA 3.0 |
added 51 characters in body
|
May 2, 2014 at 16:04 | history | answered | mallardz | CC BY-SA 3.0 |