Skip to main content
Code Review

Return to Answer

replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
Source Link

@rolfl @rolfl totally nailed it. Only a few nitpicks left behind:

  • I'd drop all pointless comments, unless they serve a purpose when you teach this
  • Add the @Override annotations for clarity when reading not in an IDE
  • Whenever you can drop this. from this.cursor, I'd drop it
  • The way you use spacing around brackets does not follow well the standard. Use the reformat function of your IDE (equivalent of Control-Shift-f in Eclipse)

I think it's a great idea asking here before presenting to your class!

@rolfl totally nailed it. Only a few nitpicks left behind:

  • I'd drop all pointless comments, unless they serve a purpose when you teach this
  • Add the @Override annotations for clarity when reading not in an IDE
  • Whenever you can drop this. from this.cursor, I'd drop it
  • The way you use spacing around brackets does not follow well the standard. Use the reformat function of your IDE (equivalent of Control-Shift-f in Eclipse)

I think it's a great idea asking here before presenting to your class!

@rolfl totally nailed it. Only a few nitpicks left behind:

  • I'd drop all pointless comments, unless they serve a purpose when you teach this
  • Add the @Override annotations for clarity when reading not in an IDE
  • Whenever you can drop this. from this.cursor, I'd drop it
  • The way you use spacing around brackets does not follow well the standard. Use the reformat function of your IDE (equivalent of Control-Shift-f in Eclipse)

I think it's a great idea asking here before presenting to your class!

added 7 characters in body
Source Link
janos
  • 112.9k
  • 15
  • 154
  • 396

@rolfl totally nailed it. Only a few insignificant nitpicks left behind:

  • Whenever you can drop this. from this.cursor, I'd drop it
  • I'd drop all pointless comments, unless they serve a purpose when you teach this
  • Add the @Override annotations for clarity when reading not in an IDE
  • Whenever you can drop this. from this.cursor, I'd drop it
  • The way you use spacing around brackets isdoes not 100%follow well the standard, use. Use the reformat function of your IDE (equivalent of Control-Shift-f in Eclipse)

I think it's a great idea asking here before presenting to your class!

@rolfl totally nailed it. Only a few insignificant nitpicks left behind:

  • Whenever you can drop this. from this.cursor, I'd drop it
  • I'd drop all pointless comments, unless they serve a purpose when you teach this
  • Add the @Override annotations for clarity when reading not in an IDE
  • The spacing around brackets is not 100% the standard, use the reformat function of your IDE (equivalent of Control-Shift-f in Eclipse)

I think it's a great idea asking here before presenting to your class!

@rolfl totally nailed it. Only a few nitpicks left behind:

  • I'd drop all pointless comments, unless they serve a purpose when you teach this
  • Add the @Override annotations for clarity when reading not in an IDE
  • Whenever you can drop this. from this.cursor, I'd drop it
  • The way you use spacing around brackets does not follow well the standard. Use the reformat function of your IDE (equivalent of Control-Shift-f in Eclipse)

I think it's a great idea asking here before presenting to your class!

Source Link
janos
  • 112.9k
  • 15
  • 154
  • 396

@rolfl totally nailed it. Only a few insignificant nitpicks left behind:

  • Whenever you can drop this. from this.cursor, I'd drop it
  • I'd drop all pointless comments, unless they serve a purpose when you teach this
  • Add the @Override annotations for clarity when reading not in an IDE
  • The spacing around brackets is not 100% the standard, use the reformat function of your IDE (equivalent of Control-Shift-f in Eclipse)

I think it's a great idea asking here before presenting to your class!

lang-java

AltStyle によって変換されたページ (->オリジナル) /