Skip to main content
Code Review

Return to Question

edited tags
Link
nhgrif
  • 25.4k
  • 3
  • 64
  • 129
Notice removed Canonical answer required by Community Bot
Bounty Ended with no winning answer by Community Bot
edited tags
Link
200_success
  • 145.5k
  • 22
  • 190
  • 478
Better formatting.
Source Link
syb0rg
  • 21.9k
  • 10
  • 113
  • 192

I'm using NSInvocation as a choke point in my app to help manage threading and reduce the amount of redundant code. The purpose of this class is to pass arguments from the view controllers to the API project on a background thread and return success/error/ on the main thread. I also have a log callback that logs apiAPI events in the background.

  1. Am I creating retain loops by passing self in any of the blocks?

    Am I creating retain loops by passing self in any of the blocks?

  2. Is this possible without using retainArguments: in the NSInvocation category?

    Is this possible without using retainArguments: in the NSInvocation category?

  3. Are there any other issues with this implementation?

    Are there any other issues with this implementation?

I'm using NSInvocation as a choke point in my app to help manage threading and reduce the amount of redundant code. The purpose of this class is to pass arguments from the view controllers to the API project on a background thread and return success/error/ on the main thread. I also have a log callback that logs api events in the background.

  1. Am I creating retain loops by passing self in any of the blocks?
  2. Is this possible without using retainArguments: in the NSInvocation category?
  3. Are there any other issues with this implementation?

I'm using NSInvocation as a choke point in my app to help manage threading and reduce the amount of redundant code. The purpose of this class is to pass arguments from the view controllers to the API project on a background thread and return success/error on the main thread. I also have a log callback that logs API events in the background.

  1. Am I creating retain loops by passing self in any of the blocks?

  2. Is this possible without using retainArguments: in the NSInvocation category?

  3. Are there any other issues with this implementation?

Notice added Canonical answer required by JeffRegan
Bounty Started worth 50 reputation by JeffRegan
Tweeted twitter.com/#!/StackCodeReview/status/447235962574483456
edited tags
Link
konijn
  • 34.2k
  • 5
  • 70
  • 267
Loading
Source Link
Loading
lang-c

AltStyle によって変換されたページ (->オリジナル) /