Skip to main content
Code Review

Return to Answer

replaced http://us2.php.net with https://www.php.net
Source Link

Try to avoid creating your own hashing function. Instead (if your PHP version allows), use the built in password_hash() password_hash() and password_verify() functions.

Your method of gaining the IP address is a start, but I think it could be more complete.

If you can, avoid using echo $r->getMessage(); as it may produce information a malicious user could exploit. Control the output given to the user.

In Member.class.php I see a lot of nested ifs. Try to flatten your code for greater readability.

Try to avoid creating your own hashing function. Instead (if your PHP version allows), use the built in password_hash() and password_verify() functions.

Your method of gaining the IP address is a start, but I think it could be more complete.

If you can, avoid using echo $r->getMessage(); as it may produce information a malicious user could exploit. Control the output given to the user.

In Member.class.php I see a lot of nested ifs. Try to flatten your code for greater readability.

Try to avoid creating your own hashing function. Instead (if your PHP version allows), use the built in password_hash() and password_verify() functions.

Your method of gaining the IP address is a start, but I think it could be more complete.

If you can, avoid using echo $r->getMessage(); as it may produce information a malicious user could exploit. Control the output given to the user.

In Member.class.php I see a lot of nested ifs. Try to flatten your code for greater readability.

replaced http://security.stackexchange.com/ with https://security.stackexchange.com/
Source Link

Try to avoid creating your own hashing avoid creating your own hashing function. Instead (if your PHP version allows), use the built in password_hash() and password_verify() functions.

Your method of gaining the IP address is a start, but I think it could be more complete.

If you can, avoid using echo $r->getMessage(); as it may produce information a malicious user could exploit. Control the output given to the user.

In Member.class.php I see a lot of nested ifs. Try to flatten your code for greater readability.

Try to avoid creating your own hashing function. Instead (if your PHP version allows), use the built in password_hash() and password_verify() functions.

Your method of gaining the IP address is a start, but I think it could be more complete.

If you can, avoid using echo $r->getMessage(); as it may produce information a malicious user could exploit. Control the output given to the user.

In Member.class.php I see a lot of nested ifs. Try to flatten your code for greater readability.

Try to avoid creating your own hashing function. Instead (if your PHP version allows), use the built in password_hash() and password_verify() functions.

Your method of gaining the IP address is a start, but I think it could be more complete.

If you can, avoid using echo $r->getMessage(); as it may produce information a malicious user could exploit. Control the output given to the user.

In Member.class.php I see a lot of nested ifs. Try to flatten your code for greater readability.

Try to avoid creating your own hashing function. Instead (if your PHP version allows), use the built in password_hash() and password_verify() functions.

Your method of gaining the IP address is a start, but I think it could be more complete it could be more complete.

If you can, avoid using echo $r->getMessage(); as it may produce information a malicious user could exploit. Control the output given to the user.

In Member.class.php I see a lot of nested ifs. Try to flatten your code for greater readability.

Try to avoid creating your own hashing function. Instead (if your PHP version allows), use the built in password_hash() and password_verify() functions.

Your method of gaining the IP address is a start, but I think it could be more complete.

If you can, avoid using echo $r->getMessage(); as it may produce information a malicious user could exploit. Control the output given to the user.

In Member.class.php I see a lot of nested ifs. Try to flatten your code for greater readability.

Try to avoid creating your own hashing function. Instead (if your PHP version allows), use the built in password_hash() and password_verify() functions.

Your method of gaining the IP address is a start, but I think it could be more complete.

If you can, avoid using echo $r->getMessage(); as it may produce information a malicious user could exploit. Control the output given to the user.

In Member.class.php I see a lot of nested ifs. Try to flatten your code for greater readability.

Source Link
Alex L
  • 5.8k
  • 2
  • 26
  • 69
Loading
lang-php

AltStyle によって変換されたページ (->オリジナル) /