Return to Answer

replaced http://programmers.stackexchange.com/ with https://softwareengineering.stackexchange.com/

edited Apr 12, 2017 at 7:31

Just a few random notes:

Instead of i and j the variables could be called as rowNumber and columnNumber.

Update for Thomas's comment: Reading (and understanding) code usually takes time but it's usually not because of long variable or method names. I'd not optimize for character number. There are debates about this topic on Programmer.SE this topic on Programmer.SE too. My favorite answer is nikie's one My favorite answer is nikie's one, beacuse of mentioning the short 7-slot (+-2) term memory.

```
cellGrid[j, i, 0]
```

0 here is a magic number. A named constant would be better.

Comments like this are unnecessary:
```
cell.BackColor = Color.White; // Color
```

It says nothing more than the code already does, it's rather noise. (Clean Code by Robert C. Martin: Chapter 4: Comments, Noise Comments)

Shorter lines, without horizontal scrolling would be easier to read.

Just a few random notes:

Instead of i and j the variables could be called as rowNumber and columnNumber.

Update for Thomas's comment: Reading (and understanding) code usually takes time but it's usually not because of long variable or method names. I'd not optimize for character number. There are debates about this topic on Programmer.SE too. My favorite answer is nikie's one, beacuse of mentioning the short 7-slot (+-2) term memory.

```
cellGrid[j, i, 0]
```

0 here is a magic number. A named constant would be better.

Comments like this are unnecessary:
```
cell.BackColor = Color.White; // Color
```

It says nothing more than the code already does, it's rather noise. (Clean Code by Robert C. Martin: Chapter 4: Comments, Noise Comments)

Shorter lines, without horizontal scrolling would be easier to read.

Just a few random notes:

Instead of i and j the variables could be called as rowNumber and columnNumber.

Update for Thomas's comment: Reading (and understanding) code usually takes time but it's usually not because of long variable or method names. I'd not optimize for character number. There are debates about this topic on Programmer.SE too. My favorite answer is nikie's one, beacuse of mentioning the short 7-slot (+-2) term memory.

```
cellGrid[j, i, 0]
```

0 here is a magic number. A named constant would be better.

Comments like this are unnecessary:
```
cell.BackColor = Color.White; // Color
```

It says nothing more than the code already does, it's rather noise. (Clean Code by Robert C. Martin: Chapter 4: Comments, Noise Comments)

Shorter lines, without horizontal scrolling would be easier to read.

added 464 characters in body

Source Link

edited Jan 26, 2014 at 10:11

palacsint

edited Jan 26, 2014 at 10:11

palacsint

30.4k
9
82
157

Just a few random notes:

Instead of i and j the variables could be called as rowNumber and columnNumber.
```
cellGrid[j, i, 0]
```
Instead of i and j the variables could be called as rowNumber and columnNumber.

Update for Thomas's comment: Reading (and understanding) code usually takes time but it's usually not because of long variable or method names. I'd not optimize for character number. There are debates about this topic on Programmer.SE too. My favorite answer is nikie's one , beacuse of mentioning the short 7-slot (+-2) term memory.

```
cellGrid[j, i, 0]
```

0 here is a magic number. A named constant would be better.

Comments like this are unnecessary:
```
cell.BackColor = Color.White; // Color
```

It says nothing more than the code already does, it's rather noise. (Clean Code by Robert C. Martin: Chapter 4: Comments, Noise Comments)

Shorter lines, without horizontal scrolling would be easier to read.

Just a few random notes:

Instead of i and j the variables could be called as rowNumber and columnNumber.
```
cellGrid[j, i, 0]
```

0 here is a magic number. A named constant would be better.

Comments like this are unnecessary:
```
cell.BackColor = Color.White; // Color
```

It says nothing more than the code already does, it's rather noise. (Clean Code by Robert C. Martin: Chapter 4: Comments, Noise Comments)

Shorter lines, without horizontal scrolling would be easier to read.

Just a few random notes:

Instead of i and j the variables could be called as rowNumber and columnNumber.

Update for Thomas's comment: Reading (and understanding) code usually takes time but it's usually not because of long variable or method names. I'd not optimize for character number. There are debates about this topic on Programmer.SE too. My favorite answer is nikie's one , beacuse of mentioning the short 7-slot (+-2) term memory.

```
cellGrid[j, i, 0]
```

0 here is a magic number. A named constant would be better.

Comments like this are unnecessary:
```
cell.BackColor = Color.White; // Color
```

It says nothing more than the code already does, it's rather noise. (Clean Code by Robert C. Martin: Chapter 4: Comments, Noise Comments)

Shorter lines, without horizontal scrolling would be easier to read.

Source Link

answered Jan 25, 2014 at 23:03

palacsint

answered Jan 25, 2014 at 23:03

palacsint

30.4k
9
82
157

Just a few random notes:

Instead of i and j the variables could be called as rowNumber and columnNumber.
```
cellGrid[j, i, 0]
```

0 here is a magic number. A named constant would be better.

Comments like this are unnecessary:
```
cell.BackColor = Color.White; // Color
```

It says nothing more than the code already does, it's rather noise. (Clean Code by Robert C. Martin: Chapter 4: Comments, Noise Comments)

Shorter lines, without horizontal scrolling would be easier to read.

lang-cs