replaced http://meta.codereview.stackexchange.com/ with https://codereview.meta.stackexchange.com/
The puzzle being parsed is the one provided as an example in the winning weekend-challenge suggestion the winning weekend-challenge suggestion.
The puzzle being parsed is the one provided as an example in the winning weekend-challenge suggestion.
The puzzle being parsed is the one provided as an example in the winning weekend-challenge suggestion.
-------------------------------------+===========+===========+===========+ | | | | 8 | 4 | | | | 9 | ------------------------------------- | | | 1 | | | | | | 5 | ------------------------------------- | 8 | | | | 2 | 1 | 4 | 6 | | +===========+===========+===========+ | 7 | | 8 | | | | | 9 | | ------------------------------------- | | | | | | | | | | ------------------------------------- | | 5 | | | | | 3 | | 1 | +===========+===========+===========+ | | 2 | 4 | 9 | 1 | | | | 7 | ------------------------------------- | 9 | | | | | | 5 | | | ------------------------------------- | 3 | | | | 8 | 4 | | | | +===========+===========+===========+
/** A 9x9 Sudoku grid */
public class SudokuGrid {
private SudokuDigit[][] digits;
/** Creates a new SudokuGrid. Specified array must be 9x9. */
public SudokuGrid(SudokuDigit[][] digits){
this.digits = digits;
}
/** Creates a new SudokuGrid from specified string, assumed to be 9 lines of 9 characters. */
public SudokuGrid(String contents) {
this(contents.split("\\r?\\n"));
}
/** Creates a new SudokuGrid from specified string array, assumed to be 9 strings of 9 characters. */
public SudokuGrid(String[] contents) {
this(parseStringContent(contents));
}
private static SudokuDigit[][] parseStringContent(String[] contents) {
SudokuDigit[][] result = new SudokuDigit[9][9];
for (int i = 0; i < 9; i++) {
String row = contents[i];
for (int j = 0; j < 9; j++) {
result[i][j] = new SudokuDigit(row.charAt(j));
}
}
return result;
}
/** Sets the value of specified grid coordinates. */
public void setDigit(Point coordinates, Integer value) {
setDigit(coordinates, new SudokuDigit(value));
}
/** Sets the value of specified grid coordinates. */
public void setDigit(Point coordinates, SudokuDigit value) {
this.digits[coordinates.x][coordinates.y] = value;
}
/** Gets the SudokuDigit at specified grid coordinates. */
public SudokuDigit getDigit(Point coordinates) {
return this.digits[coordinates.x][coordinates.y];
}
/** Gets all SudokuDigits in specified row (0-8). */
public SudokuDigit[] getRow(int row) {
return this.digits[row];
}
/** Gets all SudokuDigits in specified column (0-8). */
public SudokuDigit[] getColumn(int column) {
SudokuDigit[] result = new SudokuDigit[9];
for (int row = 0; row < 9; row++) {
result[row] = this.digits[row][column];
}
return result;
}
/** Gets all SudokuDigits in specified 3x3 region (x: 0-2, y: 0-2). */
public SudokuDigit[][] getRegion(Point coordinates) {
SudokuDigit[][] result = new SudokuDigit[3][3];
int startRow = coordinates.x * 3;
int startCol = coordinates.y * 3;
for (int row = 0; row < 3; row++) {
for (int col = 0; col < 3; col++) {
result[row][col] = this.digits[startRow + row][startCol + col];
}
}
return result;
}
public String toString() {
final String newLine = System.lineSeparator();
String result = "-------------------------------------""+===========+===========+===========+" + newLine;
for (int row = 0; row < this.digits.length; row++) {
result = result.concat("|");
for (int col = 0; col < this.digits[row].length; col++) {
result = result.concat(" " + this.digits[row][col].toString() + " |");
}
if ((row + 1) % 3 == 0) {
result = result.concat(newLine + "+===========+===========+===========+" + newLine);
}
else {
result = result.concat(newLine + "-------------------------------------" + newLine);
}
}
return result;
}
}
------------------------------------- | | | | 8 | 4 | | | | 9 | ------------------------------------- | | | 1 | | | | | | 5 | ------------------------------------- | 8 | | | | 2 | 1 | 4 | 6 | | +===========+===========+===========+ | 7 | | 8 | | | | | 9 | | ------------------------------------- | | | | | | | | | | ------------------------------------- | | 5 | | | | | 3 | | 1 | +===========+===========+===========+ | | 2 | 4 | 9 | 1 | | | | 7 | ------------------------------------- | 9 | | | | | | 5 | | | ------------------------------------- | 3 | | | | 8 | 4 | | | | +===========+===========+===========+
/** A 9x9 Sudoku grid */
public class SudokuGrid {
private SudokuDigit[][] digits;
/** Creates a new SudokuGrid. Specified array must be 9x9. */
public SudokuGrid(SudokuDigit[][] digits){
this.digits = digits;
}
/** Creates a new SudokuGrid from specified string, assumed to be 9 lines of 9 characters. */
public SudokuGrid(String contents) {
this(contents.split("\\r?\\n"));
}
/** Creates a new SudokuGrid from specified string array, assumed to be 9 strings of 9 characters. */
public SudokuGrid(String[] contents) {
this(parseStringContent(contents));
}
private static SudokuDigit[][] parseStringContent(String[] contents) {
SudokuDigit[][] result = new SudokuDigit[9][9];
for (int i = 0; i < 9; i++) {
String row = contents[i];
for (int j = 0; j < 9; j++) {
result[i][j] = new SudokuDigit(row.charAt(j));
}
}
return result;
}
/** Sets the value of specified grid coordinates. */
public void setDigit(Point coordinates, Integer value) {
setDigit(coordinates, new SudokuDigit(value));
}
/** Sets the value of specified grid coordinates. */
public void setDigit(Point coordinates, SudokuDigit value) {
this.digits[coordinates.x][coordinates.y] = value;
}
/** Gets the SudokuDigit at specified grid coordinates. */
public SudokuDigit getDigit(Point coordinates) {
return this.digits[coordinates.x][coordinates.y];
}
/** Gets all SudokuDigits in specified row (0-8). */
public SudokuDigit[] getRow(int row) {
return this.digits[row];
}
/** Gets all SudokuDigits in specified column (0-8). */
public SudokuDigit[] getColumn(int column) {
SudokuDigit[] result = new SudokuDigit[9];
for (int row = 0; row < 9; row++) {
result[row] = this.digits[row][column];
}
return result;
}
/** Gets all SudokuDigits in specified 3x3 region (x: 0-2, y: 0-2). */
public SudokuDigit[][] getRegion(Point coordinates) {
SudokuDigit[][] result = new SudokuDigit[3][3];
int startRow = coordinates.x * 3;
int startCol = coordinates.y * 3;
for (int row = 0; row < 3; row++) {
for (int col = 0; col < 3; col++) {
result[row][col] = this.digits[startRow + row][startCol + col];
}
}
return result;
}
public String toString() {
final String newLine = System.lineSeparator();
String result = "-------------------------------------" + newLine;
for (int row = 0; row < this.digits.length; row++) {
result = result.concat("|");
for (int col = 0; col < this.digits[row].length; col++) {
result = result.concat(" " + this.digits[row][col].toString() + " |");
}
if ((row + 1) % 3 == 0) {
result = result.concat(newLine + "+===========+===========+===========+" + newLine);
}
else {
result = result.concat(newLine + "-------------------------------------" + newLine);
}
}
return result;
}
}
+===========+===========+===========+ | | | | 8 | 4 | | | | 9 | ------------------------------------- | | | 1 | | | | | | 5 | ------------------------------------- | 8 | | | | 2 | 1 | 4 | 6 | | +===========+===========+===========+ | 7 | | 8 | | | | | 9 | | ------------------------------------- | | | | | | | | | | ------------------------------------- | | 5 | | | | | 3 | | 1 | +===========+===========+===========+ | | 2 | 4 | 9 | 1 | | | | 7 | ------------------------------------- | 9 | | | | | | 5 | | | ------------------------------------- | 3 | | | | 8 | 4 | | | | +===========+===========+===========+
/** A 9x9 Sudoku grid */
public class SudokuGrid {
private SudokuDigit[][] digits;
/** Creates a new SudokuGrid. Specified array must be 9x9. */
public SudokuGrid(SudokuDigit[][] digits){
this.digits = digits;
}
/** Creates a new SudokuGrid from specified string, assumed to be 9 lines of 9 characters. */
public SudokuGrid(String contents) {
this(contents.split("\\r?\\n"));
}
/** Creates a new SudokuGrid from specified string array, assumed to be 9 strings of 9 characters. */
public SudokuGrid(String[] contents) {
this(parseStringContent(contents));
}
private static SudokuDigit[][] parseStringContent(String[] contents) {
SudokuDigit[][] result = new SudokuDigit[9][9];
for (int i = 0; i < 9; i++) {
String row = contents[i];
for (int j = 0; j < 9; j++) {
result[i][j] = new SudokuDigit(row.charAt(j));
}
}
return result;
}
/** Sets the value of specified grid coordinates. */
public void setDigit(Point coordinates, Integer value) {
setDigit(coordinates, new SudokuDigit(value));
}
/** Sets the value of specified grid coordinates. */
public void setDigit(Point coordinates, SudokuDigit value) {
this.digits[coordinates.x][coordinates.y] = value;
}
/** Gets the SudokuDigit at specified grid coordinates. */
public SudokuDigit getDigit(Point coordinates) {
return this.digits[coordinates.x][coordinates.y];
}
/** Gets all SudokuDigits in specified row (0-8). */
public SudokuDigit[] getRow(int row) {
return this.digits[row];
}
/** Gets all SudokuDigits in specified column (0-8). */
public SudokuDigit[] getColumn(int column) {
SudokuDigit[] result = new SudokuDigit[9];
for (int row = 0; row < 9; row++) {
result[row] = this.digits[row][column];
}
return result;
}
/** Gets all SudokuDigits in specified 3x3 region (x: 0-2, y: 0-2). */
public SudokuDigit[][] getRegion(Point coordinates) {
SudokuDigit[][] result = new SudokuDigit[3][3];
int startRow = coordinates.x * 3;
int startCol = coordinates.y * 3;
for (int row = 0; row < 3; row++) {
for (int col = 0; col < 3; col++) {
result[row][col] = this.digits[startRow + row][startCol + col];
}
}
return result;
}
public String toString() {
final String newLine = System.lineSeparator();
String result = "+===========+===========+===========+" + newLine;
for (int row = 0; row < this.digits.length; row++) {
result = result.concat("|");
for (int col = 0; col < this.digits[row].length; col++) {
result = result.concat(" " + this.digits[row][col].toString() + " |");
}
if ((row + 1) % 3 == 0) {
result = result.concat(newLine + "+===========+===========+===========+" + newLine);
}
else {
result = result.concat(newLine + "-------------------------------------" + newLine);
}
}
return result;
}
}
Hello Java World ~> Parsing a Sudoku Grid
This is my first, very-very first attempt at java. I haven't started tackling the actual resolution of the sudoku puzzle (not even sure where to start, haven't looked at other weekend-challenge entries yet). I don't have much to go over here, but I'm sure it's filled with beginner mistakes already, so before I make things any worse I'd like to get a review of what I have.
The puzzle being parsed is the one provided as an example in the winning weekend-challenge suggestion.
public class SudokuGame {
private final static String newLine = System.lineSeparator();
private final static String puzzle =
"...84...9" + newLine +
"..1.....5" + newLine +
"8...2146." + newLine +
"7.8....9." + newLine +
"........." + newLine +
".5....3.1" + newLine +
".2491...7" + newLine +
"9.....5.." + newLine +
"3...84...";
public static void main(String[] args){
SudokuGrid grid = new SudokuGrid(puzzle);
System.out.print(grid);
}
}
The program takes the string and outputs this:
------------------------------------- | | | | 8 | 4 | | | | 9 | ------------------------------------- | | | 1 | | | | | | 5 | ------------------------------------- | 8 | | | | 2 | 1 | 4 | 6 | | +===========+===========+===========+ | 7 | | 8 | | | | | 9 | | ------------------------------------- | | | | | | | | | | ------------------------------------- | | 5 | | | | | 3 | | 1 | +===========+===========+===========+ | | 2 | 4 | 9 | 1 | | | | 7 | ------------------------------------- | 9 | | | | | | 5 | | | ------------------------------------- | 3 | | | | 8 | 4 | | | | +===========+===========+===========+
Here's the SudokuGrid class:
/** A 9x9 Sudoku grid */
public class SudokuGrid {
private SudokuDigit[][] digits;
/** Creates a new SudokuGrid. Specified array must be 9x9. */
public SudokuGrid(SudokuDigit[][] digits){
this.digits = digits;
}
/** Creates a new SudokuGrid from specified string, assumed to be 9 lines of 9 characters. */
public SudokuGrid(String contents) {
this(contents.split("\\r?\\n"));
}
/** Creates a new SudokuGrid from specified string array, assumed to be 9 strings of 9 characters. */
public SudokuGrid(String[] contents) {
this(parseStringContent(contents));
}
private static SudokuDigit[][] parseStringContent(String[] contents) {
SudokuDigit[][] result = new SudokuDigit[9][9];
for (int i = 0; i < 9; i++) {
String row = contents[i];
for (int j = 0; j < 9; j++) {
result[i][j] = new SudokuDigit(row.charAt(j));
}
}
return result;
}
/** Sets the value of specified grid coordinates. */
public void setDigit(Point coordinates, Integer value) {
setDigit(coordinates, new SudokuDigit(value));
}
/** Sets the value of specified grid coordinates. */
public void setDigit(Point coordinates, SudokuDigit value) {
this.digits[coordinates.x][coordinates.y] = value;
}
/** Gets the SudokuDigit at specified grid coordinates. */
public SudokuDigit getDigit(Point coordinates) {
return this.digits[coordinates.x][coordinates.y];
}
/** Gets all SudokuDigits in specified row (0-8). */
public SudokuDigit[] getRow(int row) {
return this.digits[row];
}
/** Gets all SudokuDigits in specified column (0-8). */
public SudokuDigit[] getColumn(int column) {
SudokuDigit[] result = new SudokuDigit[9];
for (int row = 0; row < 9; row++) {
result[row] = this.digits[row][column];
}
return result;
}
/** Gets all SudokuDigits in specified 3x3 region (x: 0-2, y: 0-2). */
public SudokuDigit[][] getRegion(Point coordinates) {
SudokuDigit[][] result = new SudokuDigit[3][3];
int startRow = coordinates.x * 3;
int startCol = coordinates.y * 3;
for (int row = 0; row < 3; row++) {
for (int col = 0; col < 3; col++) {
result[row][col] = this.digits[startRow + row][startCol + col];
}
}
return result;
}
public String toString() {
final String newLine = System.lineSeparator();
String result = "-------------------------------------" + newLine;
for (int row = 0; row < this.digits.length; row++) {
result = result.concat("|");
for (int col = 0; col < this.digits[row].length; col++) {
result = result.concat(" " + this.digits[row][col].toString() + " |");
}
if ((row + 1) % 3 == 0) {
result = result.concat(newLine + "+===========+===========+===========+" + newLine);
}
else {
result = result.concat(newLine + "-------------------------------------" + newLine);
}
}
return result;
}
}
And this is my SudokuDigit class:
/** An object that represents a single digit in a SudokuGrid, with or without a value. */
public class SudokuDigit {
private Integer digit;
/** Creates a new, empty value */
public SudokuDigit() {
this((Integer)null);
}
/** Creates a new digit from specified character. */
public SudokuDigit(char value) {
Integer numericValue;
if (value == '.') {
numericValue = null;
}
else {
numericValue = Integer.parseInt(String.valueOf(value));
}
this.digit = numericValue;
}
/** Creates a new digit with specified value */
public SudokuDigit(Integer value) {
this.digit = value;
}
/** Gets the current value of the digit. Null if no value is specified. */
public Integer getDigit() {
return this.digit;
}
/** Sets the current value of the digit.
* Specify null for no value.
* Throws UnsupportedOperationException if value is not valid.*/
public void setDigit(Integer value) {
if (!validateDigitValue(value)) throw new UnsupportedOperationException();
this.digit = value;
}
private boolean validateDigitValue(Integer value) {
return value == null || (value >= 1 && value <= 9);
}
public String toString() {
return this.digit != null ? this.digit.toString() : " ";
}
}
This is really a "Hello World!" thing, but I want this code to be the grounds for an actual Sudoku resolver (which I'll post later, when/if I manage to put it together!). Any blatant mistakes that will drive me into a brick wall?
lang-java