Skip to main content
Code Review

Return to Answer

replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
Source Link

You may (beside PKopachevsky's suggestion PKopachevsky's suggestion) as well create a new class for this with Request request being a member, and a getParameter method with the same signature as the one of Request, so you spare repeating the same request parameter again and again:

class RequestAdapter {
private Request request;
public RequestAdapter(Request request) {
 this.request = request;
}
public String getParameter(String parameterName) {
 String result = request.getParameter(parameterName);
 if (result==null) {
 System.exit(0);
 }
 return result;
}

Your may use it like this:

RequestAdapter request = new RequestAdapter(originalRequest);
final String user = request.getParameter("user");
final String pw = request.getParameter("password");
final String name = request.getParameter("name");
// and so on...

You may (beside PKopachevsky's suggestion) as well create a new class for this with Request request being a member, and a getParameter method with the same signature as the one of Request, so you spare repeating the same request parameter again and again:

class RequestAdapter {
private Request request;
public RequestAdapter(Request request) {
 this.request = request;
}
public String getParameter(String parameterName) {
 String result = request.getParameter(parameterName);
 if (result==null) {
 System.exit(0);
 }
 return result;
}

Your may use it like this:

RequestAdapter request = new RequestAdapter(originalRequest);
final String user = request.getParameter("user");
final String pw = request.getParameter("password");
final String name = request.getParameter("name");
// and so on...

You may (beside PKopachevsky's suggestion) as well create a new class for this with Request request being a member, and a getParameter method with the same signature as the one of Request, so you spare repeating the same request parameter again and again:

class RequestAdapter {
private Request request;
public RequestAdapter(Request request) {
 this.request = request;
}
public String getParameter(String parameterName) {
 String result = request.getParameter(parameterName);
 if (result==null) {
 System.exit(0);
 }
 return result;
}

Your may use it like this:

RequestAdapter request = new RequestAdapter(originalRequest);
final String user = request.getParameter("user");
final String pw = request.getParameter("password");
final String name = request.getParameter("name");
// and so on...

You may (beside PKopachevsky's suggestion) as well create a new class for this with Request request being a member, and a getParameter method with the same signature as the one of Request, so you spare repeating the same request parameter again and again:

class RequestAdapter {
private Request request;
public RequestAdapter(Request request) {
 this->request.request = request;
}
public String getParameter(String parameterName) {
 String result = request.getParameter(parameterName);
 if (result==null) {
 System.exit(0);
 }
 return result;
}

Your may use it like this:

RequestAdapter request = new RequestAdapter(originalRequest);
final String user = request.getParameter("user");
final String pw = request.getParameter("password");
final String name = request.getParameter("name");
// and so on...

(I'm not a java programmer, so there could probably be errors in the code)

You may (beside PKopachevsky's suggestion) as well create a new class for this with Request request being a member, and a getParameter method with the same signature as the one of Request, so you spare repeating the same request parameter again and again:

class RequestAdapter {
private Request request;
public RequestAdapter(Request request) {
 this->request = request;
}
public String getParameter(String parameterName) {
 String result = request.getParameter(parameterName);
 if (result==null) {
 System.exit(0);
 }
 return result;
}

Your may use it like this:

RequestAdapter request(originalRequest);
final String user = request.getParameter("user");
final String pw = request.getParameter("password");
final String name = request.getParameter("name");
// and so on...

(I'm not a java programmer, so there could probably be errors in the code)

You may (beside PKopachevsky's suggestion) as well create a new class for this with Request request being a member, and a getParameter method with the same signature as the one of Request, so you spare repeating the same request parameter again and again:

class RequestAdapter {
private Request request;
public RequestAdapter(Request request) {
 this.request = request;
}
public String getParameter(String parameterName) {
 String result = request.getParameter(parameterName);
 if (result==null) {
 System.exit(0);
 }
 return result;
}

Your may use it like this:

RequestAdapter request = new RequestAdapter(originalRequest);
final String user = request.getParameter("user");
final String pw = request.getParameter("password");
final String name = request.getParameter("name");
// and so on...
Source Link
Wolf
  • 375
  • 5
  • 18

You may (beside PKopachevsky's suggestion) as well create a new class for this with Request request being a member, and a getParameter method with the same signature as the one of Request, so you spare repeating the same request parameter again and again:

class RequestAdapter {
private Request request;
public RequestAdapter(Request request) {
 this->request = request;
}
public String getParameter(String parameterName) {
 String result = request.getParameter(parameterName);
 if (result==null) {
 System.exit(0);
 }
 return result;
}

Your may use it like this:

RequestAdapter request(originalRequest);
final String user = request.getParameter("user");
final String pw = request.getParameter("password");
final String name = request.getParameter("name");
// and so on...

(I'm not a java programmer, so there could probably be errors in the code)

lang-java

AltStyle によって変換されたページ (->オリジナル) /