Return to Answer

replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/

edited Apr 13, 2017 at 12:40

edited Apr 13, 2017 at 12:40

I'm not familiar with that framework, so I can only provide some general points:

You can rewrite the if statement to subject = ad.title or 'Reminder' (see here here).
You are a bit inconsistent with spacings (before and after =, ,, (), etc.), and string formatting (your second and third logging.info)
I'd recomment spreading both those chained filters and overly long strings over multiple lines.
Maybe you could use some helper method to derive the HTML version of the message from the plain-text version or vice versa?

I'm not familiar with that framework, so I can only provide some general points:

You can rewrite the if statement to subject = ad.title or 'Reminder' (see here).
You are a bit inconsistent with spacings (before and after =, ,, (), etc.), and string formatting (your second and third logging.info)
I'd recomment spreading both those chained filters and overly long strings over multiple lines.
Maybe you could use some helper method to derive the HTML version of the message from the plain-text version or vice versa?

I'm not familiar with that framework, so I can only provide some general points:

You can rewrite the if statement to subject = ad.title or 'Reminder' (see here).
You are a bit inconsistent with spacings (before and after =, ,, (), etc.), and string formatting (your second and third logging.info)
I'd recomment spreading both those chained filters and overly long strings over multiple lines.
Maybe you could use some helper method to derive the HTML version of the message from the plain-text version or vice versa?

fixed typo, added link to explanation of "or"

edited Jul 21, 2013 at 13:13

edited Jul 21, 2013 at 13:13

I'm not familiar with that framework, so I can only provide some general points:

You can rewrite the if statement to subject = ad.title or 'Reminder' (see here ).
You are a bit incosistentinconsistent with spacings (before and after =, ,, (), etc.), and string formatting (your second and third logging.info)
I'd recomment spreading both those chained filters and overly long strings over multiple lines.
Maybe you could use some helper method to derive the HTML version of the message from the plain-text version or vice versa?

I'm not familiar with that framework, so I can only provide some general points:

You can rewrite the if statement to subject = ad.title or 'Reminder'.
You are a bit incosistent with spacings (before and after =, ,, (), etc.), and string formatting (your second and third logging.info)
I'd recomment spreading both those chained filters and overly long strings over multiple lines.
Maybe you could use some helper method to derive the HTML version of the message from the plain-text version or vice versa?

I'm not familiar with that framework, so I can only provide some general points:

You can rewrite the if statement to subject = ad.title or 'Reminder' (see here ).
You are a bit inconsistent with spacings (before and after =, ,, (), etc.), and string formatting (your second and third logging.info)
I'd recomment spreading both those chained filters and overly long strings over multiple lines.
Maybe you could use some helper method to derive the HTML version of the message from the plain-text version or vice versa?

answered Jul 21, 2013 at 8:03

answered Jul 21, 2013 at 8:03

I'm not familiar with that framework, so I can only provide some general points:

You can rewrite the if statement to subject = ad.title or 'Reminder'.
You are a bit incosistent with spacings (before and after =, ,, (), etc.), and string formatting (your second and third logging.info)
I'd recomment spreading both those chained filters and overly long strings over multiple lines.
Maybe you could use some helper method to derive the HTML version of the message from the plain-text version or vice versa?

lang-py