Skip to main content
Code Review

Return to Answer

replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
Source Link

In addition to what Yuushi wrote Yuushi wrote:

  • It would be better to have Board validate the moves, instead of Player. That way the players would work even if you changed the size of the board. For an invalid move Board could raise an exception that you handle in the main game loop.

  • If you moved the handling of user input to the tictac function, it would be easier to understand the whole user experience.

In addition to what Yuushi wrote:

  • It would be better to have Board validate the moves, instead of Player. That way the players would work even if you changed the size of the board. For an invalid move Board could raise an exception that you handle in the main game loop.

  • If you moved the handling of user input to the tictac function, it would be easier to understand the whole user experience.

In addition to what Yuushi wrote:

  • It would be better to have Board validate the moves, instead of Player. That way the players would work even if you changed the size of the board. For an invalid move Board could raise an exception that you handle in the main game loop.

  • If you moved the handling of user input to the tictac function, it would be easier to understand the whole user experience.

added 133 characters in body
Source Link
Janne Karila
  • 10.6k
  • 21
  • 34

In addition to what Yuushi wrote:

It would be better to have Board validate the moves, instead of Player. That way the players would work even if you changed the size of the board. For an invalid move Board could raise an exception that you handle in the main game loop.

  • It would be better to have Board validate the moves, instead of Player. That way the players would work even if you changed the size of the board. For an invalid move Board could raise an exception that you handle in the main game loop.

  • If you moved the handling of user input to the tictac function, it would be easier to understand the whole user experience.

In addition to what Yuushi wrote:

It would be better to have Board validate the moves, instead of Player. That way the players would work even if you changed the size of the board. For an invalid move Board could raise an exception that you handle in the main game loop.

In addition to what Yuushi wrote:

  • It would be better to have Board validate the moves, instead of Player. That way the players would work even if you changed the size of the board. For an invalid move Board could raise an exception that you handle in the main game loop.

  • If you moved the handling of user input to the tictac function, it would be easier to understand the whole user experience.

Source Link
Janne Karila
  • 10.6k
  • 21
  • 34

In addition to what Yuushi wrote:

It would be better to have Board validate the moves, instead of Player. That way the players would work even if you changed the size of the board. For an invalid move Board could raise an exception that you handle in the main game loop.

lang-py

AltStyle によって変換されたページ (->オリジナル) /