Skip to main content
Code Review

Return to Answer

Commonmark migration
Source Link

Time to try_ again?

#Time to try_ again? TheThe closure that starts here contains several .unwrap() because some locks you do might not yield anything.

Compiler Warnings

#Compiler Warnings TheThe Rust compiler is your friend! When I compile your code on my machine, I get several warnings.

#Time to try_ again? The closure that starts here contains several .unwrap() because some locks you do might not yield anything.

#Compiler Warnings The Rust compiler is your friend! When I compile your code on my machine, I get several warnings.

Time to try_ again?

The closure that starts here contains several .unwrap() because some locks you do might not yield anything.

Compiler Warnings

The Rust compiler is your friend! When I compile your code on my machine, I get several warnings.

deleted 26 characters in body
Source Link

mpsc is a channel you can use to send data across threads. (code sample coming soon)

mpsc is a channel you can use to send data across threads. (code sample coming soon)

mpsc is a channel you can use to send data across threads.

added 459 characters in body
Source Link

Also keep in mind that there are other places where .unwrap() and .expect() are used in your application. Adding to your error enum may be necessary, but in other cases like the one above it may be as simple as rethinking the problem you were trying to solve and finding a new way to express it using the tools Rust gives you. Only add to your error enum when you're sure you've found an edge case that's probably outside of the scope of your program.

Also keep in mind that there are other places where .unwrap() and .expect() are used in your application. Adding to your error enum may be necessary, but in other cases like the one above it may be as simple as rethinking the problem you were trying to solve and finding a new way to express it using the tools Rust gives you. Only add to your error enum when you're sure you've found an edge case that's probably outside of the scope of your program.

added 3 characters in body
Source Link
Loading
added 138 characters in body
Source Link
Loading
added 1287 characters in body
Source Link
Loading
added 1287 characters in body
Source Link
Loading
added 4758 characters in body
Source Link
Loading
added 4758 characters in body
Source Link
Loading
added 1902 characters in body
Source Link
Loading
Source Link
Loading
lang-rust

AltStyle によって変換されたページ (->オリジナル) /