Skip to main content
Code Review

Return to Question

make title describe what code does instead of goals - refer to help center section "Titling your question" on https://codereview.stackexchange.com/help/how-to-ask
Source Link

How to apply best practices to javascript code User authentication, management

Hello I have recently started studying javascriptJavaScript, nodejsnodeJS, and reactjsreactJS on the front end-end, andand I have some questions about best practices to apply in this javascriptJavaScript world,. I would like to ask for opinions regarding how I could improve my code.

Starting with an example: I have 2 functions, with different ways of handling promises

Here I have a route to add a user:

How to apply best practices to javascript code

Hello I have recently started studying javascript, nodejs, and reactjs front end, and I have some questions about best practices to apply in this javascript world, I would like to ask for opinions regarding how I could improve my code.

Starting with an example I have 2 functions, with different ways of handling promises

Here I have a route to add a user

User authentication, management

I have recently started studying JavaScript, nodeJS, and reactJS on the front-end, and I have some questions about best practices to apply in this JavaScript world. I would like to ask for opinions regarding how I could improve my code.

Starting with an example: I have 2 functions, with different ways of handling promises

Here I have a route to add a user:

Post Reopened by Simon Forsberg, Ethan Bierlein, Mathieu Guindon
Post Closed as "Not suitable for this site" by πάντα ῥεῖ, Ethan Bierlein, Ben A, AlexV, pacmaninbw ♦
Split up addUsers and login functions into two code blocks and minor grammar corrections
Source Link

Hello iI have recently started studying javascript, nodejs, and reactjs front end

and, and I have some questions about best practices to apply in this javascript world, I would like to ask opinionfor opinions regarding my code how could I could improve my code.

 addUsers(req,res,next) {
 try {
 const {name,email,login} = req.body;
 User.existLogin(req.body.login)
 .then(async result => {
 if(!result){
 const password = await bcrypt.hashSync(req.body.password, 10);
 User.create({ 
 name, email, login, password }).then(result => {
 res.status(201).json({Results: result.dataValues})
 })
 }else{
 return res.status(409).json({message: 'Login already exists'}); 
 }
 })
 } catch (error) {
 res.status(500).json({error: error})
 }
}
And here I have another function to login:

And here I have another function to login:

async login(req,res){
 const user = await User.existLogin(req.body.login);
 if (!user) { return res.status(400).json({result: 'Login is wrong '});} 
 const isPassword = await User.isPassword(user.dataValues.password, req.body.password);
 if (!isPassword) { return res.status(400).json({result: 'Password is wrong '}); } 
 const jwt = auth.signjwt(auth.payload(user));
 console.log(jwt);
 res.status(200);
 res.json(jwt);
}

Hello i started studying javascript, nodejs, reactjs front end

and I have some questions about best practices to apply in this javascript world, I would like to ask opinion regarding my code how could I improve

 addUsers(req,res,next) {
 try {
 const {name,email,login} = req.body;
 User.existLogin(req.body.login)
 .then(async result => {
 if(!result){
 const password = await bcrypt.hashSync(req.body.password, 10);
 User.create({ 
 name, email, login, password }).then(result => {
 res.status(201).json({Results: result.dataValues})
 })
 }else{
 return res.status(409).json({message: 'Login already exists'}); 
 }
 })
 } catch (error) {
 res.status(500).json({error: error})
 }
}
And here I have another function to login:

async login(req,res){
 const user = await User.existLogin(req.body.login);
 if (!user) { return res.status(400).json({result: 'Login is wrong '});} 
 const isPassword = await User.isPassword(user.dataValues.password, req.body.password);
 if (!isPassword) { return res.status(400).json({result: 'Password is wrong '}); } 
 const jwt = auth.signjwt(auth.payload(user));
 console.log(jwt);
 res.status(200);
 res.json(jwt);
}

Hello I have recently started studying javascript, nodejs, and reactjs front end, and I have some questions about best practices to apply in this javascript world, I would like to ask for opinions regarding how I could improve my code.

 addUsers(req,res,next) {
 try {
 const {name,email,login} = req.body;
 User.existLogin(req.body.login)
 .then(async result => {
 if(!result){
 const password = await bcrypt.hashSync(req.body.password, 10);
 User.create({ 
 name, email, login, password }).then(result => {
 res.status(201).json({Results: result.dataValues})
 })
 }else{
 return res.status(409).json({message: 'Login already exists'}); 
 }
 })
 } catch (error) {
 res.status(500).json({error: error})
 }
}

And here I have another function to login:

async login(req,res){
 const user = await User.existLogin(req.body.login);
 if (!user) { return res.status(400).json({result: 'Login is wrong '});} 
 const isPassword = await User.isPassword(user.dataValues.password, req.body.password);
 if (!isPassword) { return res.status(400).json({result: 'Password is wrong '}); } 
 const jwt = auth.signjwt(auth.payload(user));
 console.log(jwt);
 res.status(200);
 res.json(jwt);
}
Source Link
gabriel
  • 217
  • 1
  • 2

How to apply best practices to javascript code

Hello i started studying javascript, nodejs, reactjs front end

and I have some questions about best practices to apply in this javascript world, I would like to ask opinion regarding my code how could I improve

Starting with an example I have 2 functions, with different ways of handling promises

Here I have a route to add a user

 addUsers(req,res,next) {
 try {
 const {name,email,login} = req.body;
 User.existLogin(req.body.login)
 .then(async result => {
 if(!result){
 const password = await bcrypt.hashSync(req.body.password, 10);
 User.create({ 
 name, email, login, password }).then(result => {
 res.status(201).json({Results: result.dataValues})
 })
 }else{
 return res.status(409).json({message: 'Login already exists'}); 
 }
 })
 } catch (error) {
 res.status(500).json({error: error})
 }
}
And here I have another function to login:
async login(req,res){
 const user = await User.existLogin(req.body.login);
 if (!user) { return res.status(400).json({result: 'Login is wrong '});} 
 const isPassword = await User.isPassword(user.dataValues.password, req.body.password);
 if (!isPassword) { return res.status(400).json({result: 'Password is wrong '}); } 
 const jwt = auth.signjwt(auth.payload(user));
 console.log(jwt);
 res.status(200);
 res.json(jwt);
}

Looking at this the login function seems to me to be cleaner, but I have doubts if really yours I could improve in one of two (I follow different logics to do both).

I have an auth folder, where I export functions, such as my payload, my sign, my middlware to validate my jwt, but I don't know if this is a correct decision.

const jwt = require('jsonwebtoken');
const User = require('../models/User')
const config= require('../config/dbconfig');
const moment = require('moment');
module.exports = {
 signjwt (payload) {
 return jwt.sign(payload, 
 config.secretToken
 )
 },
 payload (usuario) {
 return {
 sub: usuario.id,
 name: usuario.nome,
 email: usuario.email,
 login: usuario.username,
 admin: true,
 iat: Math.floor(moment.now()/1000), // Timestamp de hoje
 exp: moment().add(10, 'minutes').unix() // Validade de 2 dias
 }
 },
 async auth(req,res,next){
 const token = req.header('Authorization');
 console.log(token);
 if(!token) return res.status(401).json('Unauthorized');
 try{
 const decoded = jwt.verify(token,config.secretToken);
 const user = await User.findByPk(decoded.sub);
 console.log(user);
 if(!user){
 return res.status(404).json('User not Found');
 }
 res.json(user);
 next();
 }catch(error){
 console.error(error);
 res.status(400).json('Invalid Token');
 }
 }
}
default

AltStyle によって変換されたページ (->オリジナル) /