Skip to main content
Code Review

Return to Answer

replaced http://stackoverflow.com/ with https://stackoverflow.com/
Source Link

#logoh1

Your <div id="logo"></div> should be a h1, otherwise the document outline wouldn't be correct:

<h1><img id="logo" src="logo.png" alt="Progress Business Company"></h1>

See http://stackoverflow.com/a/14920215/1591669 https://stackoverflow.com/a/14920215/1591669 for an explanation.

#bannerheader or aside

If your <div id="banner"></div> doesn't contain main content, it should go in an aside element, or, if it can be understood as part of the header (probably on each page of the site), in the header element.

#mainsection (or article)

Instead of <div id="main"></div> you could use a sectioning element here. I assume your div contains a heading ("Welcome, dear visitor!"), so you have something like an implict section anyhow. Why not make it explicit? So use a section instead of the div (depending on the actual content, article might be suitable instead).

#content > asidesection

I'd say on the front page the testimonials could be considered part of the main content (in the end it depends on the real content/context), so instead of aside you could use section then.

Each single testimonial should be in its own article, of course.

#extra > articlesection

I don't think article elements in the footer are suitable for that kind of content (unless your actual page contains something different). (Only the newsletter form could possibly get article instead of section, but that's not that clear; personally I'd use section for it, too).

So, I'd go with section here. If the contact details listed under "Address" are relevant for the whole page, you should use the address element, too.

<div id="extra">
 <section class="extra"></section>
 <section class="extra">
 <h1>Address</h1>
 <address>...</address>
 </section>
 <section class="extra"></section>
 <section class="extra"></section>
</div>

#logoh1

Your <div id="logo"></div> should be a h1, otherwise the document outline wouldn't be correct:

<h1><img id="logo" src="logo.png" alt="Progress Business Company"></h1>

See http://stackoverflow.com/a/14920215/1591669 for an explanation.

#bannerheader or aside

If your <div id="banner"></div> doesn't contain main content, it should go in an aside element, or, if it can be understood as part of the header (probably on each page of the site), in the header element.

#mainsection (or article)

Instead of <div id="main"></div> you could use a sectioning element here. I assume your div contains a heading ("Welcome, dear visitor!"), so you have something like an implict section anyhow. Why not make it explicit? So use a section instead of the div (depending on the actual content, article might be suitable instead).

#content > asidesection

I'd say on the front page the testimonials could be considered part of the main content (in the end it depends on the real content/context), so instead of aside you could use section then.

Each single testimonial should be in its own article, of course.

#extra > articlesection

I don't think article elements in the footer are suitable for that kind of content (unless your actual page contains something different). (Only the newsletter form could possibly get article instead of section, but that's not that clear; personally I'd use section for it, too).

So, I'd go with section here. If the contact details listed under "Address" are relevant for the whole page, you should use the address element, too.

<div id="extra">
 <section class="extra"></section>
 <section class="extra">
 <h1>Address</h1>
 <address>...</address>
 </section>
 <section class="extra"></section>
 <section class="extra"></section>
</div>

#logoh1

Your <div id="logo"></div> should be a h1, otherwise the document outline wouldn't be correct:

<h1><img id="logo" src="logo.png" alt="Progress Business Company"></h1>

See https://stackoverflow.com/a/14920215/1591669 for an explanation.

#bannerheader or aside

If your <div id="banner"></div> doesn't contain main content, it should go in an aside element, or, if it can be understood as part of the header (probably on each page of the site), in the header element.

#mainsection (or article)

Instead of <div id="main"></div> you could use a sectioning element here. I assume your div contains a heading ("Welcome, dear visitor!"), so you have something like an implict section anyhow. Why not make it explicit? So use a section instead of the div (depending on the actual content, article might be suitable instead).

#content > asidesection

I'd say on the front page the testimonials could be considered part of the main content (in the end it depends on the real content/context), so instead of aside you could use section then.

Each single testimonial should be in its own article, of course.

#extra > articlesection

I don't think article elements in the footer are suitable for that kind of content (unless your actual page contains something different). (Only the newsletter form could possibly get article instead of section, but that's not that clear; personally I'd use section for it, too).

So, I'd go with section here. If the contact details listed under "Address" are relevant for the whole page, you should use the address element, too.

<div id="extra">
 <section class="extra"></section>
 <section class="extra">
 <h1>Address</h1>
 <address>...</address>
 </section>
 <section class="extra"></section>
 <section class="extra"></section>
</div>
added 310 characters in body
Source Link
unor
  • 2.7k
  • 15
  • 24

#logoh1

Your <div id="logo"></div> should be a h1, otherwise the document outline wouldn't be correct:

<h1><img id="logo" src="logo.png" alt="Progress Business Company"></h1>

See http://stackoverflow.com/a/14920215/1591669 for an explanation.

#bannerheader or aside

If your <div id="banner"></div> doesn't contain main content, it should go in an aside element, or, if it can be understood as part of the header (probably on each page of the site), in the header element.

#mainsection (or article)

Instead of <div id="main"></div> you could use a sectioning element here. I assume your div contains a heading ("Welcome, dear visitor!"), so you have something like an implict section anyhow. Why not make it explicit? So use a section instead of the div (depending on the actual content, article might be suitable instead).

#content > asidesection

I'd say on the front page the testimonials could be considered part of the main content (in the end it depends on the real content/context), so instead of aside you could use section then.

Each single testimonial should be in its own article, of course.

#extra > articlesection

I don't think article elements in the footer are suitable for that kind of content (unless your actual page contains something different). (onlyOnly the newsletter form could possibly get article instead of section, but that's not that clear; personally I'd use section for it, too).

So, I'd go with section here. If the contact details listed unterunder "Address" are relevant for the whole page, you should use thethe address element, too.

<div id="extra">
 <section class="extra"></section>
 <section class="extra">
 <h1>Address</h1>
 <address>...</address>
 </section>
 <section class="extra"></section>
 <section class="extra"></section>
</div>

#logoh1

Your <div id="logo"></div> should be a h1, otherwise the document outline wouldn't be correct:

<h1><img id="logo" src="logo.png" alt="Progress Business Company"></h1>

See http://stackoverflow.com/a/14920215/1591669 for an explanation.

#bannerheader or aside

If your <div id="banner"></div> doesn't contain main content, it should go in an aside element, or, if it can be understood as part of the header (probably on each page of the site), in the header element.

#mainsection (or article)

Instead of <div id="main"></div> you could use a sectioning element here. I assume your div contains a heading ("Welcome, dear visitor!"), so you have something like an implict section anyhow. Why not make it explicit? So use a section instead of the div (depending on the actual content, article might be suitable instead).

#extra > articlesection

I don't think article elements in the footer are suitable for that kind of content (unless your actual page contains something different). (only the newsletter form could possibly get article instead of section, but that's not that clear; personally I'd use section for it, too).

I'd go with section here. If the contact details listed unter "Address" are relevant for the whole page, you should use the address element, too.

<div id="extra">
 <section class="extra"></section>
 <section class="extra">
 <h1>Address</h1>
 <address>...</address>
 </section>
 <section class="extra"></section>
 <section class="extra"></section>
</div>

#logoh1

Your <div id="logo"></div> should be a h1, otherwise the document outline wouldn't be correct:

<h1><img id="logo" src="logo.png" alt="Progress Business Company"></h1>

See http://stackoverflow.com/a/14920215/1591669 for an explanation.

#bannerheader or aside

If your <div id="banner"></div> doesn't contain main content, it should go in an aside element, or, if it can be understood as part of the header (probably on each page of the site), in the header element.

#mainsection (or article)

Instead of <div id="main"></div> you could use a sectioning element here. I assume your div contains a heading ("Welcome, dear visitor!"), so you have something like an implict section anyhow. Why not make it explicit? So use a section instead of the div (depending on the actual content, article might be suitable instead).

#content > asidesection

I'd say on the front page the testimonials could be considered part of the main content (in the end it depends on the real content/context), so instead of aside you could use section then.

Each single testimonial should be in its own article, of course.

#extra > articlesection

I don't think article elements in the footer are suitable for that kind of content (unless your actual page contains something different). (Only the newsletter form could possibly get article instead of section, but that's not that clear; personally I'd use section for it, too).

So, I'd go with section here. If the contact details listed under "Address" are relevant for the whole page, you should use the address element, too.

<div id="extra">
 <section class="extra"></section>
 <section class="extra">
 <h1>Address</h1>
 <address>...</address>
 </section>
 <section class="extra"></section>
 <section class="extra"></section>
</div>
Source Link
unor
  • 2.7k
  • 15
  • 24

#logoh1

Your <div id="logo"></div> should be a h1, otherwise the document outline wouldn't be correct:

<h1><img id="logo" src="logo.png" alt="Progress Business Company"></h1>

See http://stackoverflow.com/a/14920215/1591669 for an explanation.

#bannerheader or aside

If your <div id="banner"></div> doesn't contain main content, it should go in an aside element, or, if it can be understood as part of the header (probably on each page of the site), in the header element.

#mainsection (or article)

Instead of <div id="main"></div> you could use a sectioning element here. I assume your div contains a heading ("Welcome, dear visitor!"), so you have something like an implict section anyhow. Why not make it explicit? So use a section instead of the div (depending on the actual content, article might be suitable instead).

#extra > articlesection

I don't think article elements in the footer are suitable for that kind of content (unless your actual page contains something different). (only the newsletter form could possibly get article instead of section, but that's not that clear; personally I'd use section for it, too).

I'd go with section here. If the contact details listed unter "Address" are relevant for the whole page, you should use the address element, too.

<div id="extra">
 <section class="extra"></section>
 <section class="extra">
 <h1>Address</h1>
 <address>...</address>
 </section>
 <section class="extra"></section>
 <section class="extra"></section>
</div>
lang-html

AltStyle によって変換されたページ (->オリジナル) /