Skip to main content
Code Review

Return to Question

Commonmark migration
Source Link

I tried to solve a merge two sorted list problem in leetcodes:

Merge two sorted linked lists and return it as a new list. The new list should be made by splicing together the nodes of the first two lists.

###Example:

Example:

Input: 1->2->4, 1->3->4
Output: 1->1->2->3->4->4

class Solution:
 def mergeTwoLists(self, l1: ListNode, l2: ListNode) -> ListNode:
 """
 Plan:
 Compare l1 and l2 and merge the remainders
 """
 l3_head = ListNode(0)
 l3_cur = l3_head
 
 while l1 and l2: #assert both exist
 if l2.val < l1.val:
 l3_cur.next = l2 #build l3's node
 l2 = l2.next #this is i++ 
 else:
 l3_cur.next = l1
 l1 = l1.next 
 l3_cur = l3_cur.next #find the next to build
 if l1:
 l3_cur.next = l1 
 if l2:
 l3_cur.next = l2
 return l3_head.next

I assumed this is a decent solution but got:

Runtime: 56 ms, faster than 23.98% of Python3 online submissions for Merge Two Sorted Lists.

Memory Usage: 13.1 MB, less than 5.06% of Python3 online submissions for Merge Two Sorted Lists.

How could I improve my solution?

I tried to solve a merge two sorted list problem in leetcodes:

Merge two sorted linked lists and return it as a new list. The new list should be made by splicing together the nodes of the first two lists.

###Example:

Input: 1->2->4, 1->3->4
Output: 1->1->2->3->4->4

class Solution:
 def mergeTwoLists(self, l1: ListNode, l2: ListNode) -> ListNode:
 """
 Plan:
 Compare l1 and l2 and merge the remainders
 """
 l3_head = ListNode(0)
 l3_cur = l3_head
 
 while l1 and l2: #assert both exist
 if l2.val < l1.val:
 l3_cur.next = l2 #build l3's node
 l2 = l2.next #this is i++ 
 else:
 l3_cur.next = l1
 l1 = l1.next 
 l3_cur = l3_cur.next #find the next to build
 if l1:
 l3_cur.next = l1 
 if l2:
 l3_cur.next = l2
 return l3_head.next

I assumed this is a decent solution but got:

Runtime: 56 ms, faster than 23.98% of Python3 online submissions for Merge Two Sorted Lists.

Memory Usage: 13.1 MB, less than 5.06% of Python3 online submissions for Merge Two Sorted Lists.

How could I improve my solution?

I tried to solve a merge two sorted list problem in leetcodes:

Merge two sorted linked lists and return it as a new list. The new list should be made by splicing together the nodes of the first two lists.

Example:

Input: 1->2->4, 1->3->4
Output: 1->1->2->3->4->4

class Solution:
 def mergeTwoLists(self, l1: ListNode, l2: ListNode) -> ListNode:
 """
 Plan:
 Compare l1 and l2 and merge the remainders
 """
 l3_head = ListNode(0)
 l3_cur = l3_head
 
 while l1 and l2: #assert both exist
 if l2.val < l1.val:
 l3_cur.next = l2 #build l3's node
 l2 = l2.next #this is i++ 
 else:
 l3_cur.next = l1
 l1 = l1.next 
 l3_cur = l3_cur.next #find the next to build
 if l1:
 l3_cur.next = l1 
 if l2:
 l3_cur.next = l2
 return l3_head.next

I assumed this is a decent solution but got:

Runtime: 56 ms, faster than 23.98% of Python3 online submissions for Merge Two Sorted Lists.

Memory Usage: 13.1 MB, less than 5.06% of Python3 online submissions for Merge Two Sorted Lists.

How could I improve my solution?

edited tags and title
Source Link
Toby Speight
  • 87.9k
  • 14
  • 104
  • 325

merge Splice-merge two sorted listlists in a decent solution but get low scoresPython

I tried to solve a merge two sorted list problem in leetcodes:

Merge two sorted linked lists and return it as a new list. The new list should be made by splicing together the nodes of the first two lists.

Example: ###Example:

Input: 1->2->4, 1->3->4
Output: 1->1->2->3->4->4

class Solution:
 def mergeTwoLists(self, l1: ListNode, l2: ListNode) -> ListNode:
 """
 Plan:
 Compare l1 and l2 and merge the remainders
 """
 l3_head = ListNode(0)
 l3_cur = l3_head
 
 while l1 and l2: #assert both exist
 if l2.val < l1.val:
 l3_cur.next = l2 #build l3's node
 l2 = l2.next #this is i++ 
 else:
 l3_cur.next = l1
 l1 = l1.next 
 l3_cur = l3_cur.next #find the next to build
 if l1:
 l3_cur.next = l1 
 if l2:
 l3_cur.next = l2
 return l3_head.next

I assumed this is a decent solution but got:

Runtime: 56 ms, faster than 23.98% of Python3 online submissions for Merge Two Sorted Lists.

Memory Usage: 13.1 MB, less than 5.06% of Python3 online submissions for Merge Two Sorted Lists.

Next challenges:

How could I improve my solution?

merge two sorted list in a decent solution but get low scores

I tried to solve a merge two sorted list problem in leetcodes

Merge two sorted linked lists and return it as a new list. The new list should be made by splicing together the nodes of the first two lists.

Example:

Input: 1->2->4, 1->3->4
Output: 1->1->2->3->4->4

class Solution:
 def mergeTwoLists(self, l1: ListNode, l2: ListNode) -> ListNode:
 """
 Plan:
 Compare l1 and l2 and merge the remainders
 """
 l3_head = ListNode(0)
 l3_cur = l3_head
 
 while l1 and l2: #assert both exist
 if l2.val < l1.val:
 l3_cur.next = l2 #build l3's node
 l2 = l2.next #this is i++ 
 else:
 l3_cur.next = l1
 l1 = l1.next 
 l3_cur = l3_cur.next #find the next to build
 if l1:
 l3_cur.next = l1 
 if l2:
 l3_cur.next = l2
 return l3_head.next

I assumed this is a decent solution but got

Runtime: 56 ms, faster than 23.98% of Python3 online submissions for Merge Two Sorted Lists.

Memory Usage: 13.1 MB, less than 5.06% of Python3 online submissions for Merge Two Sorted Lists.

Next challenges:

How could improve my solution?

Splice-merge two sorted lists in Python

I tried to solve a merge two sorted list problem in leetcodes:

Merge two sorted linked lists and return it as a new list. The new list should be made by splicing together the nodes of the first two lists.

###Example:

Input: 1->2->4, 1->3->4
Output: 1->1->2->3->4->4

class Solution:
 def mergeTwoLists(self, l1: ListNode, l2: ListNode) -> ListNode:
 """
 Plan:
 Compare l1 and l2 and merge the remainders
 """
 l3_head = ListNode(0)
 l3_cur = l3_head
 
 while l1 and l2: #assert both exist
 if l2.val < l1.val:
 l3_cur.next = l2 #build l3's node
 l2 = l2.next #this is i++ 
 else:
 l3_cur.next = l1
 l1 = l1.next 
 l3_cur = l3_cur.next #find the next to build
 if l1:
 l3_cur.next = l1 
 if l2:
 l3_cur.next = l2
 return l3_head.next

I assumed this is a decent solution but got:

Runtime: 56 ms, faster than 23.98% of Python3 online submissions for Merge Two Sorted Lists.

Memory Usage: 13.1 MB, less than 5.06% of Python3 online submissions for Merge Two Sorted Lists.

How could I improve my solution?

deleted 5 characters in body
Source Link
Reinderien
  • 71k
  • 5
  • 76
  • 256

I tried to solve a merge two sorted list problem in leetcodes

Merge two sorted linked lists and return it as a new list. The new list should be made by splicing together the nodes of the first two lists.

Example:

Input: 1->2->4, 1->3->4
Output: 1->1->2->3->4->4

class Solution:
 def mergeTwoLists(self, l1: ListNode, l2: ListNode) -> ListNode:
 """
 Plan:
 Compare l1 and l2 and merge the remainders
 """
 l3_head = ListNode(0)
 l3_cur = l3_head
 
 while l1 and l2: #assert both exist
 if l2.val < l1.val:
 l3_cur.next = l2 #build l3's node
 l2 = l2.next #this is i++ 
 else:
 l3_cur.next = l1
 l1 = l1.next 
 l3_cur = l3_cur.next #find the next to build
 if l1:
 l3_cur.next = l1 
 if l2:
 l3_cur.next = l2
 return l3_head.next

I assumed this is a decent solution but got

Runtime: 56 ms, faster than 23.98% of Python3 online submissions for Merge Two Sorted Lists.

Memory Usage: 13.1 MB, less than 5.06% of Python3 online submissions for Merge Two Sorted Lists.

Next challenges:

How could improve my solution?

I tried to solve a merge two sorted list problem in leetcodes

Merge two sorted linked lists and return it as a new list. The new list should be made by splicing together the nodes of the first two lists.

Example:

Input: 1->2->4, 1->3->4
Output: 1->1->2->3->4->4

class Solution:
 def mergeTwoLists(self, l1: ListNode, l2: ListNode) -> ListNode:
 """
 Plan:
 Compare l1 and l2 and merge the remainders
 """
 l3_head = ListNode(0)
 l3_cur = l3_head
 
 while l1 and l2: #assert both exist
 if l2.val < l1.val:
 l3_cur.next = l2 #build l3's node
 l2 = l2.next #this is i++ 
 else:
 l3_cur.next = l1
 l1 = l1.next 
 l3_cur = l3_cur.next #find the next to build
 if l1:
 l3_cur.next = l1 
 if l2:
 l3_cur.next = l2
 return l3_head.next

I assumed this is a decent solution but got

Runtime: 56 ms, faster than 23.98% of Python3 online submissions for Merge Two Sorted Lists.

Memory Usage: 13.1 MB, less than 5.06% of Python3 online submissions for Merge Two Sorted Lists.

Next challenges:

How could improve my solution?

I tried to solve a merge two sorted list problem in leetcodes

Merge two sorted linked lists and return it as a new list. The new list should be made by splicing together the nodes of the first two lists.

Example:

Input: 1->2->4, 1->3->4
Output: 1->1->2->3->4->4

class Solution:
 def mergeTwoLists(self, l1: ListNode, l2: ListNode) -> ListNode:
 """
 Plan:
 Compare l1 and l2 and merge the remainders
 """
 l3_head = ListNode(0)
 l3_cur = l3_head
 
 while l1 and l2: #assert both exist
 if l2.val < l1.val:
 l3_cur.next = l2 #build l3's node
 l2 = l2.next #this is i++ 
 else:
 l3_cur.next = l1
 l1 = l1.next 
 l3_cur = l3_cur.next #find the next to build
 if l1:
 l3_cur.next = l1 
 if l2:
 l3_cur.next = l2
 return l3_head.next

I assumed this is a decent solution but got

Runtime: 56 ms, faster than 23.98% of Python3 online submissions for Merge Two Sorted Lists.

Memory Usage: 13.1 MB, less than 5.06% of Python3 online submissions for Merge Two Sorted Lists.

Next challenges:

How could improve my solution?

Source Link
Alice
  • 625
  • 5
  • 13
Loading
lang-py

AltStyle によって変換されたページ (->オリジナル) /