Skip to main content
Code Review

Return to Answer

Bounty Awarded with 25 reputation awarded by Community Bot
deleted 50 characters in body
Source Link
zrooda
  • 186
  • 4

Whoever told you thisMessy would imply that the code readability is messy hasn't seen messy or doesbad, which is not understand what messy means. At the same time, it has some glaring issuescase. However...

  1. Your HTML is pretty much one big div. Semantics have value, so use proper elements for the adequate job. That's why we have semantic elements in the first place. Also, there's little reason to use anything else than the HTML5 doctype in this day and age. Overall, your absolute lack of HTML semantics is the greatest issue as it produces most collateral damage.

  2. Meyer's reset, while popular, is rather obsolete today and goes unnecessarily far (check out normalize.css, you might prefer it). While CSS can be bent in almost any way as long as you're confident in the outcome, I would say you lack experience to prototype a layout correctly. Far too many specific classes, the structure can be more generalized and shared. While I haven't tried your code, it appears to be very static (one dimension change requiring more dependant changes).

  3. Your JS searches the DOM for the same elements too much and on every function execution, this is unnecessary. Define their instances and reuse them.

If any of this is unclear, I'll be happy to go in further detail or expand the answer.

Whoever told you this is messy hasn't seen messy or does not understand what messy means. At the same time, it has some glaring issues.

  1. Your HTML is pretty much one big div. Semantics have value, so use proper elements for the adequate job. That's why we have semantic elements in the first place. Also, there's little reason to use anything else than the HTML5 doctype in this day and age. Overall, your absolute lack of HTML semantics is the greatest issue as it produces most collateral damage.

  2. Meyer's reset, while popular, is rather obsolete today and goes unnecessarily far (check out normalize.css, you might prefer it). While CSS can be bent in almost any way as long as you're confident in the outcome, I would say you lack experience to prototype a layout correctly. Far too many specific classes, the structure can be more generalized and shared. While I haven't tried your code, it appears to be very static (one dimension change requiring more dependant changes).

  3. Your JS searches the DOM for the same elements too much and on every function execution, this is unnecessary. Define their instances and reuse them.

If any of this is unclear, I'll be happy to go in further detail or expand the answer.

Messy would imply that the code readability is bad, which is not the case. However...

  1. Your HTML is pretty much one big div. Semantics have value, so use proper elements for the adequate job. That's why we have semantic elements in the first place. Also, there's little reason to use anything else than the HTML5 doctype in this day and age. Overall, your absolute lack of HTML semantics is the greatest issue as it produces most collateral damage.

  2. Meyer's reset, while popular, is rather obsolete today and goes unnecessarily far (check out normalize.css, you might prefer it). While CSS can be bent in almost any way as long as you're confident in the outcome, I would say you lack experience to prototype a layout correctly. Far too many specific classes, the structure can be more generalized and shared. While I haven't tried your code, it appears to be very static (one dimension change requiring more dependant changes).

  3. Your JS searches the DOM for the same elements too much and on every function execution, this is unnecessary. Define their instances and reuse them.

If any of this is unclear, I'll be happy to go in further detail or expand the answer.

added 22 characters in body
Source Link
zrooda
  • 186
  • 4

Whoever told you this is messy hasn't seen messy or does not understand what messy means. At the same time, it has some glaring issues.

  1. Your HTML is pretty much one big div. Semantics have value, so use proper elements for the adequate job. That's why we have semantic elements in the first place. Also, there's little reason to use anything else than the HTML5 doctype in this day and age. Overall, your absolute lack of HTML semantics is the greatest issue as it produces most collateral damage.

  2. Meyer's reset, while popular, is rather obsolete today and goes unnecessarily far (check out normalize.css, you might prefer it). While CSS can be bent in almost any way as long as you're confident in the outcome, I would say you lack experience to prototype a layout correctly. Far too many specific classes, the structure can be more generalized and shared. While I haven't tried your code, it appears to be very static (one dimension change requiring more dependant changes).

  3. Your JS searches the DOM for the same elements too much and on every function execution, this is unnecessary. Define their instances and reuse them.

If any of this is unclear, I'll be happy to go in further detail or expand the answer.

Whoever told you this is messy hasn't seen messy or does not understand what messy means. At the same time, it has some glaring issues.

  1. Your HTML is pretty much one big div. Semantics have value, so use proper elements for the adequate job. That's why we have semantic elements in the first place. Also, there's little reason to use anything else than the HTML5 doctype in this day and age. Overall, your absolute lack of HTML semantics is the greatest issue as it produces most collateral damage.

  2. Meyer's reset, while popular, is rather obsolete today and goes unnecessarily far (check out normalize.css, you might prefer it). While CSS can be bent in almost any way as long as you're confident in the outcome, I would say you lack experience to prototype a layout correctly. Far too many specific classes, the structure can be more generalized and shared. While I haven't tried your code, it appears to be very static (one dimension change requiring ).

  3. Your JS searches the DOM for the same elements too much and on every function execution, this is unnecessary. Define their instances and reuse them.

If any of this is unclear, I'll be happy to go in further detail or expand the answer.

Whoever told you this is messy hasn't seen messy or does not understand what messy means. At the same time, it has some glaring issues.

  1. Your HTML is pretty much one big div. Semantics have value, so use proper elements for the adequate job. That's why we have semantic elements in the first place. Also, there's little reason to use anything else than the HTML5 doctype in this day and age. Overall, your absolute lack of HTML semantics is the greatest issue as it produces most collateral damage.

  2. Meyer's reset, while popular, is rather obsolete today and goes unnecessarily far (check out normalize.css, you might prefer it). While CSS can be bent in almost any way as long as you're confident in the outcome, I would say you lack experience to prototype a layout correctly. Far too many specific classes, the structure can be more generalized and shared. While I haven't tried your code, it appears to be very static (one dimension change requiring more dependant changes).

  3. Your JS searches the DOM for the same elements too much and on every function execution, this is unnecessary. Define their instances and reuse them.

If any of this is unclear, I'll be happy to go in further detail or expand the answer.

Source Link
zrooda
  • 186
  • 4

Whoever told you this is messy hasn't seen messy or does not understand what messy means. At the same time, it has some glaring issues.

  1. Your HTML is pretty much one big div. Semantics have value, so use proper elements for the adequate job. That's why we have semantic elements in the first place. Also, there's little reason to use anything else than the HTML5 doctype in this day and age. Overall, your absolute lack of HTML semantics is the greatest issue as it produces most collateral damage.

  2. Meyer's reset, while popular, is rather obsolete today and goes unnecessarily far (check out normalize.css, you might prefer it). While CSS can be bent in almost any way as long as you're confident in the outcome, I would say you lack experience to prototype a layout correctly. Far too many specific classes, the structure can be more generalized and shared. While I haven't tried your code, it appears to be very static (one dimension change requiring ).

  3. Your JS searches the DOM for the same elements too much and on every function execution, this is unnecessary. Define their instances and reuse them.

If any of this is unclear, I'll be happy to go in further detail or expand the answer.

lang-css

AltStyle によって変換されたページ (->オリジナル) /